New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649601 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Sep 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ durga.behera@chromium.org
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Theme not getting applied to the URL's at the bottom of page.

Project Member Reported by bj00129...@techmahindra.com, Sep 23 2016 
Version: 55.0.2868.0 Dev
OS:Ubuntu 14.04

URL:
1.https://chrome.google.com/webstore/detail/into-the-storm/kpgabbidopbbiilaipddnilkkndkbcmg?utm_source=chrome-ntp-icon
2.https://chrome.google.com/webstore/detail/blue-rose/bkofacaddcdfbpmghnlpdgdeienflcoh?utm_source=chrome-ntp-icon

What steps will reproduce the problem?
(1)Launch Chrome>>Go to  any of the above URLs to add Theme
(2)After the theme gets loaded open NTP>>Now hover the Mouse on any thumbnails and observe URL at the bottom of the Page (Please refer Video and Screenshot)

Expected:Even URL's at the bottom of the page should be seen in the added theme.
Actual:Instead Theme not getting applied to the URL's at the bottom of page.

Note: 
1.This issue is only seen after fresh installation of the build but not on upgrading.
2.This issue is working fine in Incognito window.
3.Issue is not seen in windows.


This is Regression issue broken in M-55. Will update bisect info soon.

Manual bisect info:
Good build:55.0.2844.0
Bad build:54.0.2845.0

Attaching screen-cast for reference.
Actual_Theme.ogv
4.5 MB View Download
Actual_Theme.png
1.1 MB View Download
Expected_Theme.png
1.1 MB View Download

Comment 1 by msrchandra@chromium.org, Sep 23 2016

Labels: -Needs-Bisect hasbisect-per-revision
Owner: bsep@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2844.0 (Revision: 415023).
Bad build: 55.0.2845.0 (Revision: 415522).

You are probably looking for a change made after 415215 (known good), but no later than 415216 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/9d638a1ee2933e62dccaed16eef64e64cbe2ded9..e5a8ba6722632879cfa09ef0e7f8d7f4a99c5d4e

From the CL above, assigning the issue to the concern owner --
@bsep -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.

Comment 2 Deleted

Comment 3 by bsep@chromium.org, Sep 23 2016 

Hmm yeah it's probably my patch. I'm a bit confused as to why it'd show up on Linux and not Windows, because they share that code. I'll take a look.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbf5bacde72383a2b88fd476bfd1bc5460a20ae7

commit cbf5bacde72383a2b88fd476bfd1bc5460a20ae7
Author: bsep <bsep@chromium.org>
Date: Sat Sep 24 21:28:32 2016

Fix status bar color not updating when applying a theme on Linux.

Linux does not create a new StatusBubbleViews::StatusView when applying
a theme, so it needs the ThemeProvider passed in to get the new colors.

BUG= 649601 

Review-Url: https://codereview.chromium.org/2364063003
Cr-Commit-Position: refs/heads/master@{#420851}

[modify] https://crrev.com/cbf5bacde72383a2b88fd476bfd1bc5460a20ae7/chrome/browser/ui/views/status_bubble_views.cc

Comment 5 by bsep@chromium.org, Sep 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment