Issue metadata
Sign in to add a comment
|
Regression: [MD-Settings]Unnecessary 'Relaunch' button is seen even after relaunching the browser.
Reported by
dmascare...@etouch.net,
Sep 23 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:55.0.2869.0 (Official Build) 333a7dd429e44a6562112fc29c667474fa2e92f9-refs/heads/master@{#420536} OS: Windows (7,8,10) What steps will reproduce the problem? 1. Launch chrome and chrome://md-settings/languages 2. Click on drop down arrow and then click on 'Relaunch' button which is beside English language. 3. After browser relaunched again click on drop down arrow of 'Languages' section,Observe. Actual: Unnecessary 'Relaunch' button is seen even after step 3. Expected: 'Relaunch' button should not be seen after step 3. This is regression issue, broken in 'M 55' and will soon update the bisect info Good build:55.0.2868.0 Bad build:55.0.2869.0 Will soon provide the Mac and Linux OS info.
,
Sep 23 2016
Note:1. Unable to check issue on Linux OS as build is not available.
2. Issue is not reproducible on Mac OS.
,
Sep 26 2016
michaelpg@: Could you please take a look at this. Cc'ing stevenjb@ as well for more inputs.
,
Sep 29 2016
Friendly ping to get an update on this issue. There is no 'Relaunch' button seen on Linux Ubuntu 14.04, chrome version:55.0.2875.0. Please review the blocker label and update this thread as probable M-55 branch date is due for next week or so.
,
Sep 29 2016
This bug is reported as M55 Beta blocker.Please try to resolve this before M55 branch on Oct 6th,2016 so it has enough baking time in Dev.
,
Oct 3 2016
Removing the Beta blocker and punting this to Stable blocker for M-55. michaelpg@/stevenjb@: Please update the blocker label if you feel this should not be blocking and update accordingly as per C#5.
,
Oct 12 2016
able to reproduce the issue on windows 7 using chrome latest chrome version 56.0.2888.0. could any one please look into this issue.
,
Oct 19 2016
michaelpg@ Can we know what's the status of the fix,since we are about to promote M55 to Beta and we need to get the fix into branch soon which on 19th-oct.
,
Oct 25 2016
MD Settings bugs are never branch blockers, please do not mark them as such. chrome://md-settings is not used by default without a flag being set.
,
Dec 13 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4cb2126002cd187035ba90ee13ebda77e16d81f6 commit 4cb2126002cd187035ba90ee13ebda77e16d81f6 Author: michaelpg <michaelpg@chromium.org> Date: Wed Dec 14 02:46:48 2016 Language settings: Fix Restart and Remove buttons shown at wrong times Language settings makes the faulty assumption that the app locale (navigator.language) will match the the preferred app locale (intl.app_locale). For some languages, we map a language code to a different locale. For example, en-ZA is mapped to en-GB when getting the application locale, so the preference won't match the actual locale used. See l10n_util::CheckAndResolveLocale for other wacky examples. Stop using navigator.language when the intl.app_locale pref is available. Also move more logic into the model and stop checking intl.app_locale in the UI. Use a more defensive check for the Restart button: show if the locale preference has changed from its initial value. BUG= 561227 , 649588 , 633661 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2573643005 Cr-Commit-Position: refs/heads/master@{#438403} [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages.js [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/resources/settings/languages_page/languages_types.js [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/ui/webui/settings/languages_handler.cc [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/browser/ui/webui/settings/languages_handler.h [modify] https://crrev.com/4cb2126002cd187035ba90ee13ebda77e16d81f6/chrome/test/data/webui/settings/languages_tests.js
,
Dec 17 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Sep 23 2016Owner: michae...@chromium.org
Status: Assigned (was: Unconfirmed)