New issue
Advanced search Search tips

Issue 649581 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Need a better debug approach for PaintArtifacts

Project Member Reported by pdr@chromium.org, Sep 23 2016

Issue description

I keep re-writing the same debug code and others on the team are as well.

I think we should add the following:
String PaintArtifact::toString() {
    StringBuilder sb;
    sb.append("DisplayItems:");
    for (auto& item : m_displayItemList) {
        sb.append([index]);
        sb.append(item.toString();
    }

    sb.append("PaintChunks:");
    for (auto& chunk : paintChunks)
        sb.append(chunk.toString());

    sb.append("Property trees:");
    // Collect and print the trees, similar to PaintPropertyTreePrinter::showAllPropertyTrees
}

String PaintChunk::toString() {
    begin index, end index, and pointers for the 4 property tree nodes
}
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 25 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold BugSource-Team PaintTeamTriaged-20170925
Owner: pdr@chromium.org
Status: Assigned (was: Untriaged)
Is this done now?

Comment 3 by pdr@chromium.org, Sep 25 2017

We added a lot more logging so this is mostly done, but I think I still need a ToString on PaintArtifact. Will add.

Sign in to add a comment