New issue
Advanced search Search tips

Issue 649559 link

Starred by 2 users
Status: Fixed
Owner:
ellyjo...@chromium.org
Closed: Nov 2016
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

MacViews: Tabbing away from a textfield causes NSBeep

Project Member Reported by tapted@chromium.org, Sep 23 2016 
Chrome Version       : 55.0.2868.0
OS Version: OS X 10.11.6

Probably from r419473 "views: provide feedback when editing fails"

What steps will reproduce the problem?
0. chrome://flags/#mac-views-native-dialogs enabled
1. Click bookmark star
2. Press tab

What is the expected result?

No NSBeep()

What happens instead of that?

NSBeep()

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2859.0 Safari/537.36
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48a12e434146dc568dabb364d84be911b6d369e4

commit 48a12e434146dc568dabb364d84be911b6d369e4
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Oct 07 18:00:08 2016

views: don't send OnKeypressUnhandled for all keys

Textfield::OnKeyPressed() is not responsible for all keystroke handling,
but it is called for every pressed key, which means that 'handled' in
this function is not correct if the key is handled elsewhere, like IME
or focus hotkeys. As such, don't call OnKeypressUnhandled() in OnKeyPressed()
at all; only call it in InsertChar() for readonly textfields.

BUG= 649559 ,  649007 

Review-Url: https://codereview.chromium.org/2399603002
Cr-Commit-Position: refs/heads/master@{#423908}

[modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/style/platform_style.cc
[modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/style/platform_style.h
[modify] https://crrev.com/48a12e434146dc568dabb364d84be911b6d369e4/ui/views/style/platform_style_mac.mm

Comment 2 by ellyjo...@chromium.org, Nov 7 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment