New issue
Advanced search Search tips

Issue 649545 link

Starred by 2 users
Status: Assigned
Owner:
est...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

reuse omnibox drop shadow for infobars

Project Member Reported by est...@chromium.org, Sep 23 2016 
Although it would probably still be nice to draw once onto an image and then blit it, because that's probably more performant than re-rendering a gradient or shadow on every paint.

Also, we want to experiment with reusing the same bottom shadow for the infobar drop shadow.
2016-09-22.png
19.7 KB View Download
2016-09-22 (1).png
1.4 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10019689c629250717e1035fcdd9365852109ff6

commit 10019689c629250717e1035fcdd9365852109ff6
Author: estade <estade@chromium.org>
Date: Tue Sep 27 18:08:26 2016

Views - draw omnibox popup shadows

They come out looking a little different than the png assets we were
using, which is intentional. Screenshots at 1x and 2x are sgabriel-
approved.

BUG=649545
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2364163002
Cr-Commit-Position: refs/heads/master@{#421266}

[delete] https://crrev.com/fe132d9d1a03966649118030e50715d1a063f73c/chrome/app/theme/default_100_percent/common/omnibox_dropdown_shadow_bottom.png
[delete] https://crrev.com/fe132d9d1a03966649118030e50715d1a063f73c/chrome/app/theme/default_100_percent/common/omnibox_dropdown_shadow_top.png
[delete] https://crrev.com/fe132d9d1a03966649118030e50715d1a063f73c/chrome/app/theme/default_200_percent/common/omnibox_dropdown_shadow_bottom.png
[delete] https://crrev.com/fe132d9d1a03966649118030e50715d1a063f73c/chrome/app/theme/default_200_percent/common/omnibox_dropdown_shadow_top.png
[modify] https://crrev.com/10019689c629250717e1035fcdd9365852109ff6/chrome/app/theme/theme_resources.grd
[modify] https://crrev.com/10019689c629250717e1035fcdd9365852109ff6/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/10019689c629250717e1035fcdd9365852109ff6/chrome/browser/ui/layout_constants.h
[modify] https://crrev.com/10019689c629250717e1035fcdd9365852109ff6/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/10019689c629250717e1035fcdd9365852109ff6/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h

Comment 2 by est...@chromium.org, Oct 24 2016

Summary: reuse omnibox drop shadow for infobars (was: manually draw omnibox shadow (instead of tiling a png))
re-titling
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec14a768c3422dd386db2db1416a1d83a45a6969

commit ec14a768c3422dd386db2db1416a1d83a45a6969
Author: estade <estade@chromium.org>
Date: Thu Oct 27 16:53:16 2016

Refactor ShadowImageSource into ui/gfx/skia_util for better reuse

Planning to use it for at least the CrOS system menu UI and browser
infobars.

BUG=649545,649802

Review-Url: https://codereview.chromium.org/2443983003
Cr-Commit-Position: refs/heads/master@{#428057}

[modify] https://crrev.com/ec14a768c3422dd386db2db1416a1d83a45a6969/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc
[modify] https://crrev.com/ec14a768c3422dd386db2db1416a1d83a45a6969/ui/gfx/image/image_skia_operations.cc
[modify] https://crrev.com/ec14a768c3422dd386db2db1416a1d83a45a6969/ui/gfx/image/image_skia_operations.h
►

Sign in to add a comment