The chromium.perf.fyi Win Clang Builder is broken |
|||
Issue descriptionI think it stopped working in the gn migration.
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3345574ddb50494df05d1ed8579d51415863d506 commit 3345574ddb50494df05d1ed8579d51415863d506 Author: hans <hans@chromium.org> Date: Fri Sep 23 03:50:39 2016 mb: Add a recipe for the chromium.perf.fyi Win Clang Builder BUG= 649539 Review-Url: https://codereview.chromium.org/2358083004 Cr-Commit-Position: refs/heads/master@{#420569} [modify] https://crrev.com/3345574ddb50494df05d1ed8579d51415863d506/tools/mb/mb_config.pyl
,
Sep 23 2016
The bot is still not running the 'generate build files' step: https://build.chromium.org/p/chromium.perf.fyi/builders/Win%20Clang%20Builder/builds/25095 I figure I need to add 'mb' to the recipe config somehow, but haven't been able to find a way yet. +dtu, you refactored this in https://codereview.chromium.org/2256123002 can you help me out?
,
Sep 23 2016
> +dtu, you refactored this in https://codereview.chromium.org/2256123002 can you help me out? Actually, this seems to work, but I'm not sure if it's The Right Way: https://codereview.chromium.org/2365933002
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3215ef3233f90481f50275a9acdb5ba3b2709421 commit 3215ef3233f90481f50275a9acdb5ba3b2709421 Author: hans <hans@chromium.org> Date: Fri Sep 23 17:24:18 2016 perf.fyi: Add 'mb' to the Win Clang Builder BUG= 649539 TBR=dtu Review-Url: https://codereview.chromium.org/2365933002 [modify] https://crrev.com/3215ef3233f90481f50275a9acdb5ba3b2709421/scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py [modify] https://crrev.com/3215ef3233f90481f50275a9acdb5ba3b2709421/scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Win_Clang_Builder.json
,
Sep 23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/ae048ae7bda5c28b323dbadc51eaf39ff092a28c commit ae048ae7bda5c28b323dbadc51eaf39ff092a28c Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 17:38:56 2016
,
Sep 23 2016
I wonder if this requires a waterfall restart? The first build with my patch didn't run the mb step: https://build.chromium.org/p/chromium.perf.fyi/builders/Win%20Clang%20Builder/builds/25098 I think restarts aren't required for recipe changes, but here I'm not really sure what I'm changing.
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2f107f56592dade631ce1f54011fb5199fc9d0e7 commit 2f107f56592dade631ce1f54011fb5199fc9d0e7 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 18:07:35 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3215ef3233f90481f50275a9acdb5ba3b2709421 perf.fyi: Add 'mb' to the Win Clang Builder (hans@chromium.org) https://crrev.com/1e981b104f83d776d978309ad58bd61e7ec1e1b1 Remove 'ChromiumOS GN' builders from master.chromium.chromiumos. (dpranke@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= 649539 , 649579 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2362313002 Cr-Commit-Position: refs/heads/master@{#420660} [modify] https://crrev.com/2f107f56592dade631ce1f54011fb5199fc9d0e7/infra/config/recipes.cfg
,
Sep 23 2016
> I think restarts aren't required for recipe changes, but here I'm not really sure what I'm changing. Never mind, it seems to have picked it up now: https://build.chromium.org/p/chromium.perf.fyi/builders/Win%20Clang%20Builder/builds/25100
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ceeb603d5fbdb401a38921f7d5836388e8f75bfd commit ceeb603d5fbdb401a38921f7d5836388e8f75bfd Author: hans <hans@chromium.org> Date: Tue Sep 27 18:40:29 2016 mb: Enable goma and minimal_symbols for perf.fyi Win Clang Builder BUG= 649539 Review-Url: https://codereview.chromium.org/2371953002 Cr-Commit-Position: refs/heads/master@{#421280} [modify] https://crrev.com/ceeb603d5fbdb401a38921f7d5836388e8f75bfd/tools/mb/mb_config.pyl
,
Sep 28 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by h...@chromium.org
, Sep 23 2016