New issue
Advanced search Search tips

Issue 649539 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

The chromium.perf.fyi Win Clang Builder is broken

Project Member Reported by h...@chromium.org, Sep 22 2016

Issue description

I think it stopped working in the gn migration.
 

Comment 1 by h...@chromium.org, Sep 23 2016

Cc: thakis@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3345574ddb50494df05d1ed8579d51415863d506

commit 3345574ddb50494df05d1ed8579d51415863d506
Author: hans <hans@chromium.org>
Date: Fri Sep 23 03:50:39 2016

mb: Add a recipe for the chromium.perf.fyi Win Clang Builder

BUG= 649539 

Review-Url: https://codereview.chromium.org/2358083004
Cr-Commit-Position: refs/heads/master@{#420569}

[modify] https://crrev.com/3345574ddb50494df05d1ed8579d51415863d506/tools/mb/mb_config.pyl

Comment 3 Deleted

Comment 4 Deleted

Comment 5 by h...@chromium.org, Sep 23 2016

Cc: dtu@chromium.org
The bot is still not running the 'generate build files' step: https://build.chromium.org/p/chromium.perf.fyi/builders/Win%20Clang%20Builder/builds/25095

I figure I need to add 'mb' to the recipe config somehow, but haven't been able to find a way yet.

+dtu, you refactored this in https://codereview.chromium.org/2256123002 can you help me out?

Comment 6 by h...@chromium.org, Sep 23 2016

> +dtu, you refactored this in https://codereview.chromium.org/2256123002 can you help me out?

Actually, this seems to work, but I'm not sure if it's The Right Way:
https://codereview.chromium.org/2365933002
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 23 2016

Comment 9 by h...@chromium.org, Sep 23 2016

I wonder if this requires a waterfall restart? The first build with my patch didn't run the mb step: https://build.chromium.org/p/chromium.perf.fyi/builders/Win%20Clang%20Builder/builds/25098

I think restarts aren't required for recipe changes, but here I'm not really sure what I'm changing.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f107f56592dade631ce1f54011fb5199fc9d0e7

commit 2f107f56592dade631ce1f54011fb5199fc9d0e7
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 18:07:35 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3215ef3233f90481f50275a9acdb5ba3b2709421 perf.fyi: Add 'mb' to the Win Clang Builder (hans@chromium.org)
  https://crrev.com/1e981b104f83d776d978309ad58bd61e7ec1e1b1 Remove 'ChromiumOS GN' builders from master.chromium.chromiumos. (dpranke@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 649539 , 649579 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2362313002
Cr-Commit-Position: refs/heads/master@{#420660}

[modify] https://crrev.com/2f107f56592dade631ce1f54011fb5199fc9d0e7/infra/config/recipes.cfg

Comment 11 by h...@chromium.org, Sep 23 2016

> I think restarts aren't required for recipe changes, but here I'm not really sure what I'm changing.

Never mind, it seems to have picked it up now:
https://build.chromium.org/p/chromium.perf.fyi/builders/Win%20Clang%20Builder/builds/25100
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ceeb603d5fbdb401a38921f7d5836388e8f75bfd

commit ceeb603d5fbdb401a38921f7d5836388e8f75bfd
Author: hans <hans@chromium.org>
Date: Tue Sep 27 18:40:29 2016

mb: Enable goma and minimal_symbols for perf.fyi Win Clang Builder

BUG= 649539 

Review-Url: https://codereview.chromium.org/2371953002
Cr-Commit-Position: refs/heads/master@{#421280}

[modify] https://crrev.com/ceeb603d5fbdb401a38921f7d5836388e8f75bfd/tools/mb/mb_config.pyl

Comment 13 by h...@chromium.org, Sep 28 2016

Status: Fixed (was: Started)

Sign in to add a comment