New issue
Advanced search Search tips

Issue 649529 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Recipe Engine FetchError doesn't show details!

Project Member Reported by d...@chromium.org, Sep 22 2016

Issue description

FetchError is listed, but does not show details:

From https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Builder__dbg_%2F112888%2F%2B%2Frecipes%2Fstderr

INFO:requests.packages.urllib3.connectionpool:Starting new HTTPS connection (1): chromium.googlesource.com
Traceback (most recent call last):
  File "/b/.remote_run_cipd/recipes.py", line 568, in <module>
    ret = main()
  File "/b/.remote_run_cipd/recipes.py", line 508, in main
    return remote(args)
  File "/b/.remote_run_cipd/recipes.py", line 182, in remote
    return remote.main(args)
  File "/b/.remote_run_cipd/recipe_engine/remote.py", line 44, in main
    args.repository, args.revision, checkout_dir, allow_fetch=True)
@@@STEP_LINK@stdout-->stdio@https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FAndroid_Builder__dbg_%2F112888%2F%2B%2Frecipes%2Fstdout@@@
  File "/b/.remote_run_cipd/recipe_engine/fetch.py", line 60, in wrapper
    return f(*args, **kwargs)
  File "/b/.remote_run_cipd/recipe_engine/fetch.py", line 185, in checkout
    revision = self._resolve_revision(repo, revision)
  File "/b/.remote_run_cipd/recipe_engine/fetch.py", line 273, in _resolve_revision
    rev_json = self._revision_metadata(repo, revision)
  File "/b/.remote_run_cipd/recipe_engine/fetch.py", line 267, in _revision_metadata
    '%s/+/%s?format=JSON' % (repo, requests.utils.quote(revision)))
  File "/b/.remote_run_cipd/recipe_engine/fetch.py", line 282, in _fetch_gitiles_json
    raise FetchError('Unexpected gitiles response: %s' % raw)
recipe_engine.fetch.FetchError

This should show at least the HTTP error code and server message related to the failure. This is relevant to at least one trooper outage.
 
Owner: phajdan.jr@chromium.org
Status: Assigned (was: Untriaged)
Owner: martiniss@chromium.org
Status: Started (was: Assigned)
See https://codereview.chromium.org/2365693002

Comment 3 by d...@chromium.org, Sep 23 2016

Owner: d...@chromium.org
Ended up doing this in parallel. We're opting to go with my CL, so I'll take this bug over.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/15ab08227b961ddce83db7e41fb83b9288ff9ccc

commit 15ab08227b961ddce83db7e41fb83b9288ff9ccc
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 02:05:58 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649466 , chromium:649529 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2360143005

[modify] https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc/infra/config/recipes.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/3e8973fd8aef93211db73c3eb873b04581fd2e32

commit 3e8973fd8aef93211db73c3eb873b04581fd2e32
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 02:14:29 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649466 , chromium:649529 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2359933006

[modify] https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32/infra/config/recipes.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 23 2016

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a42a0f11843dc18c6457cd22b064ff0f32aa5b86

commit a42a0f11843dc18c6457cd22b064ff0f32aa5b86
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 02:36:55 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649466 , chromium:649529 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354413005
Cr-Commit-Position: refs/heads/master@{#420551}

[modify] https://crrev.com/a42a0f11843dc18c6457cd22b064ff0f32aa5b86/infra/config/recipes.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5145014b011cca1ca05d332dda590fa1061a7cea

commit 5145014b011cca1ca05d332dda590fa1061a7cea
Author: recipe-roller <recipe-roller@chromium.org>
Date: Fri Sep 23 02:55:27 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/e33d22aee513e6e4385251d3160dc94308cbf262 Revert of [swarming/api] Add text in to indicate whether a shard is failing (patchset #4 id:70001 of https://codereview.chromium.org/2362733002/ ) (nednguyen@google.com)
  https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/60ebc91bfe416e751ba02606db5292e244457d24 Use [CACHE]/cipd/goma for goma_dir in recipe_modules/chromium/config.py (tikuta@chromium.org)
depot_tools:
  https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= chromium:649466 , chromium:639321 , chromium:649529 ,621828

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2363773004

[modify] https://crrev.com/5145014b011cca1ca05d332dda590fa1061a7cea/infra/config/recipes.cfg

Comment 9 by d...@chromium.org, Sep 23 2016

Status: Fixed (was: Started)
Bugdroid didn't link, but this should be fixed with: https://codereview.chromium.org/2362993002

Sign in to add a comment