Show shell_surface shadow underlay when voice feedback is enabled. |
|||
Issue descriptionWe want to center-maximize (or maximize if resizable) android apps when talkback is enabled. When this happens, chrome should extend the shadow_underlay and have it capture located events and make a sound. This is the chrome-side part of this change (just the shadow underlay stuff). Window positioning will be handled on android side.
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f31b7767effd9ea9e17f07820b94fe895687dea commit 9f31b7767effd9ea9e17f07820b94fe895687dea Author: erosky <erosky@chromium.org> Date: Tue Oct 04 01:10:16 2016 Draw underlay behind android apps using talkback When spoken-feedback is enabled, shell_surface's shadow_underlay will fill the screen for active android windows. When in this mode, the underlay will consume all events and play an earcon to indicate that the event was located outside the android window. BUG= 649524 TEST=unit-test and tested on device Review-Url: https://codereview.chromium.org/2361993003 Cr-Commit-Position: refs/heads/master@{#422651} [modify] https://crrev.com/9f31b7767effd9ea9e17f07820b94fe895687dea/components/exo/BUILD.gn [modify] https://crrev.com/9f31b7767effd9ea9e17f07820b94fe895687dea/components/exo/DEPS [modify] https://crrev.com/9f31b7767effd9ea9e17f07820b94fe895687dea/components/exo/shell_surface.cc [modify] https://crrev.com/9f31b7767effd9ea9e17f07820b94fe895687dea/components/exo/shell_surface.h [modify] https://crrev.com/9f31b7767effd9ea9e17f07820b94fe895687dea/components/exo/shell_surface_unittest.cc
,
Oct 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/998c256b3f707cdecdab750239f70b7e893747a1 commit 998c256b3f707cdecdab750239f70b7e893747a1 Author: erosky <erosky@chromium.org> Date: Wed Oct 19 22:00:08 2016 Only exclude workarea from touch-exploration with active shell-surface The previous behavior disabled touch-exploration altogether which made the shelf un-explorable. This adds support for an exclusion region in touch_exploration_controller. When a shell-surface is active, that region gets set to the workarea (area above shelf and below chromevox banner) so that the shelf remains explorable. BUG= 649524 TEST=unit-test for exclude-area support. manual for shell-surface behavior. Review-Url: https://chromiumcodereview.appspot.com/2378773011 Cr-Commit-Position: refs/heads/master@{#426299} [modify] https://crrev.com/998c256b3f707cdecdab750239f70b7e893747a1/ash/ash_touch_exploration_manager_chromeos.cc [modify] https://crrev.com/998c256b3f707cdecdab750239f70b7e893747a1/ash/ash_touch_exploration_manager_chromeos.h [modify] https://crrev.com/998c256b3f707cdecdab750239f70b7e893747a1/components/exo/pointer.cc [modify] https://crrev.com/998c256b3f707cdecdab750239f70b7e893747a1/ui/chromeos/touch_exploration_controller.cc [modify] https://crrev.com/998c256b3f707cdecdab750239f70b7e893747a1/ui/chromeos/touch_exploration_controller.h [modify] https://crrev.com/998c256b3f707cdecdab750239f70b7e893747a1/ui/chromeos/touch_exploration_controller_unittest.cc
,
Apr 6 2017
,
May 8 2017
Chrome OS 9532.0.0, 60.0.3092.0 |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Oct 4 2016