New issue
Advanced search Search tips

Issue 649523 link

Starred by 2 users
Status: Fixed
Owner:
jrumm...@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Allow users to see and remove EME/CDM data by domain

Project Member Reported by jrumm...@chromium.org, Sep 22 2016 
There needs to be a way for users to see and remove EME/CDM data on a per domain basis, similar to the way users can see and remove cookies, local storage, database storage, etc. The latter are currently viewed (and optionally removed) using the "Cookies and site data" dialog (chrome://settings/cookies).

Issue 418195 allows users to clear all media licenses by selecting "Media licenses" in the "Clear Browsing Data" dialog to clear the EME/CDM data for all domains, if it exists. So this would add a "Media license" node to any domain that has a media license saved in the "Cookies and site data" dialog.

Selecting the media license should display origin, size on disk, and last modified time, the same as is done for other storage types. The data for the media license is encrypted, so there is no need to display the contents of the license.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e

commit 6f67ebbd8bf03b554ac5630b69124d8bea31cd9e
Author: jrummell <jrummell@chromium.org>
Date: Thu Oct 13 21:24:34 2016

Adds media license nodes to cookie tree model and cookies view.

Adds a new node "Media license" when appropriate to the cookie
tree model and displayis it in the "Cookies and site data" dialog.
When selected, it displays details of media license (origin,
size on disk, last modified time) in the details frame.

BUG= 649523 
TEST=new tests pass
As well, nodes show up in the cookies dialog after visiting a site
that uses media licenses.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2359393002
Cr-Commit-Position: refs/heads/master@{#425166}

[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/app/generated_resources.grd
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/BUILD.gn
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/android/preferences/website_preference_bridge.cc
[add] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/browsing_data_media_license_helper.cc
[add] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/browsing_data_media_license_helper.h
[add] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/browsing_data_media_license_helper_unittest.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/cookies_tree_model.h
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/cookies_tree_model_unittest.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/local_data_container.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/local_data_container.h
[add] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/mock_browsing_data_media_license_helper.cc
[add] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/browsing_data/mock_browsing_data_media_license_helper.h
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/content_settings/local_shared_objects_container.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/resources/options/cookies_list.js
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/resources/settings/site_settings/cookie_info.js
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/ui/webui/cookies_tree_model_util.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/ui/webui/options/cookies_view_handler.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/chrome/test/BUILD.gn
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/storage/browser/fileapi/plugin_private_file_system_backend.cc
[modify] https://crrev.com/6f67ebbd8bf03b554ac5630b69124d8bea31cd9e/storage/browser/fileapi/plugin_private_file_system_backend.h

Comment 2 by jrumm...@chromium.org, Oct 13 2016

Status: Fixed (was: Started)
►

Sign in to add a comment