New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649484 link

Starred by 3 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Sep 2016
Cc:
█ warx@chromium.org
thomasanderson@chromium.org
sky@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

interactive_test_utils_aura window->show() is not right for linux platform

Project Member Reported by warx@chromium.org, Sep 22 2016 
For a call of ShowAndFocusNativeWindowAura on linux platform, desktop_window_tree_host_ may still not be active: https://cs.chromium.org/chromium/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc?q=desktop_native_&sq=package:chromium&l=784

Consider changing it to views::Widget::GetWidgetForNativeWindow(window)->Show();

Comment 1 by sky@chromium.org, Sep 22 2016

Cc: thomasanderson@chromium.org

Comment 2 by thomasanderson@chromium.org, Sep 22 2016

Owner: thomasanderson@chromium.org
I recently changed DWTHX11 to not Activate() on Show()
https://codereview.chromium.org/2295443002/

Based on the name ShowAndFocusNativeWindowAura, I think we should just call Show() and then Activate() from that function instead of just Show(). (here https://cs.chromium.org/chromium/src/chrome/test/base/interactive_test_utils_aura.cc?rcl=1474529952&l=27)

Comment 3 by thomasanderson@chromium.org, Sep 22 2016

Cc: warx@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79cad3c950be7bff3b166b2c350770aaeca051fb

commit 79cad3c950be7bff3b166b2c350770aaeca051fb
Author: thomasanderson <thomasanderson@google.com>
Date: Mon Sep 26 21:44:40 2016

Aura: Focus() in ShowAndFocusNativeWindowAura

R=sky@chromium.org

BUG= 649484 

Review-Url: https://codereview.chromium.org/2353353005
Cr-Commit-Position: refs/heads/master@{#421004}

[modify] https://crrev.com/79cad3c950be7bff3b166b2c350770aaeca051fb/chrome/test/base/interactive_test_utils_aura.cc

Comment 5 by thomasanderson@chromium.org, Sep 26 2016 

warx@ can you verify that #4 solves the issue you were seeing?

Comment 6 by warx@chromium.org, Sep 27 2016

Status: Fixed (was: Assigned)
Yes, it solves.

Comment 7 by warx@chromium.org, Sep 27 2016 

Thanks
►

Sign in to add a comment