Recipe engine can't handle strange gitiles responses |
|||||||
Issue descriptionSee https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.android%2Fandroid_n5x_swarming_rel%2F34660%2F%2B%2Frecipes%2Fstderr for an example File "/b/.remote_run_cipd/recipe_engine/fetch.py", line 193, in checkout recipes_cfg_text = base64.b64decode(recipes_cfg_request.text) File "/usr/lib/python2.7/base64.py", line 73, in b64decode return binascii.a2b_base64(s) UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 1467: ordinal not in range(128) Exception above. This really shouldn't be happening; somehow requests is giving us some weird stuff, it looks like. We should add some logging about these errors, and try to figure out what exactly is causing this error.
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/15ab08227b961ddce83db7e41fb83b9288ff9ccc commit 15ab08227b961ddce83db7e41fb83b9288ff9ccc Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 02:05:58 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) recipe_engine: https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:649466 , chromium:649529 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2360143005 [modify] https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc/infra/config/recipes.cfg
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3e8973fd8aef93211db73c3eb873b04581fd2e32 commit 3e8973fd8aef93211db73c3eb873b04581fd2e32 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 02:14:29 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) depot_tools: https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:649466 , chromium:649529 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2359933006 [modify] https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32/infra/config/recipes.cfg
,
Sep 23 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/1d7cf9efc4876b5af8134711cf9d580fa7e8a5cb commit 1d7cf9efc4876b5af8134711cf9d580fa7e8a5cb Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 02:25:14 2016
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a42a0f11843dc18c6457cd22b064ff0f32aa5b86 commit a42a0f11843dc18c6457cd22b064ff0f32aa5b86 Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 02:36:55 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) depot_tools: https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:649466 , chromium:649529 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2354413005 Cr-Commit-Position: refs/heads/master@{#420551} [modify] https://crrev.com/a42a0f11843dc18c6457cd22b064ff0f32aa5b86/infra/config/recipes.cfg
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/5145014b011cca1ca05d332dda590fa1061a7cea commit 5145014b011cca1ca05d332dda590fa1061a7cea Author: recipe-roller <recipe-roller@chromium.org> Date: Fri Sep 23 02:55:27 2016 Roll recipe dependencies (trivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/e33d22aee513e6e4385251d3160dc94308cbf262 Revert of [swarming/api] Add text in to indicate whether a shard is failing (patchset #4 id:70001 of https://codereview.chromium.org/2362733002/ ) (nednguyen@google.com) https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32 Roll recipe dependencies (trivial). (recipe-roller@chromium.org) https://crrev.com/60ebc91bfe416e751ba02606db5292e244457d24 Use [CACHE]/cipd/goma for goma_dir in recipe_modules/chromium/config.py (tikuta@chromium.org) depot_tools: https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org) recipe_engine: https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG= chromium:649466 , chromium:639321 , chromium:649529 ,621828 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2363773004 [modify] https://crrev.com/5145014b011cca1ca05d332dda590fa1061a7cea/infra/config/recipes.cfg
,
Sep 23 2016
,
Oct 20 2016
Issue 649465 has been merged into this issue.
,
Oct 20 2016
An update; this is a hard bug to solve. The problem appears to be that gitiles is not strongly consistent, so when we request a recently committed commit, it sometimes 404s. Ideally, we'd be able to pass a flag to gitiles to say that we're ok waiting for a while to get a consistent result. I'm not sure what the next steps are here. I believe tandrii@ dealt with this a while ago, can you comment?
,
Oct 21 2016
I haven't dealt with it, just predicted things like this would happen. Filed https://b.corp.google.com/issues/32325912
,
May 15 2017
gitiles stuff in fetch.py is lower priority for now.
,
May 16 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 16 2018
,
May 16 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by martiniss@google.com
, Sep 22 2016