New issue
Advanced search Search tips

Issue 649464 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 621599



Sign in to add a comment

w3c-test-autoroller: update-css fails due to local commits on branch (from updating wpt).

Project Member Reported by qyears...@chromium.org, Sep 22 2016

Issue description

Example build:

https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7715

Log excerpt:

## Checkout has local commits; aborting. Use --allow-local-commits to allow this.

In theory the wpt update shouldn't affect the css update, so we could just pass --allow-local-commits when updating the css repo, but it seems more correct to make a fresh branch.

The reason why update-w3c-deps aborts if there are local commits by default is so that when it runs, chromium/src is in a known, recorded state.
 
Blocking: 621599
What is causing the problem? Where are the local commits coming from?
Coming from updating wpt in the previous step; note, there's a CL for this here: https://chromium-review.googlesource.com/#/c/388612/
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/ed520934c09765bf1d18242041c96de680d20fa6

commit ed520934c09765bf1d18242041c96de680d20fa6
Author: Quinten Yearsley <qyearsley@google.com>
Date: Wed Sep 28 16:26:22 2016

w3c-test-autoroller: Checkout new branch for updating csswg-test.

BUG= 649464 

Change-Id: Idcde975c5bb86648977acf1afd12673402e7052f
Reviewed-on: https://chromium-review.googlesource.com/388612
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[modify] https://crrev.com/ed520934c09765bf1d18242041c96de680d20fa6/recipes/recipes/w3c_test_autoroller.expected/w3c-test-autoroller.json
[modify] https://crrev.com/ed520934c09765bf1d18242041c96de680d20fa6/recipes/recipes/w3c_test_autoroller.py

Status: Fixed (was: Started)

Sign in to add a comment