TabsTest#testIncognitoTabsNotRestoredAfterSwipe flakes a lot on slower devices
Reported by
kra...@amazon.com,
Sep 22 2016
|
|||||
Issue descriptionChrome Version : Tip of master OS: Android (any version) What steps will reproduce the problem? 1. Repeatedly run TabsTest#testIncognitoTabsNotRestoredAfterSwipe on a slower device What is the expected result? The test passes 100% What happens instead? Fails about 90% of the time: C 18.379s Main [FAIL] org.chromium.chrome.browser.TabsTest#testIncognitoTabsNotRestoredAfterSwipe: C 18.379s Main junit.framework.AssertionFailedError: /data/data/org.chromium.chrome/app_tabs/0/cryptonito4 C 18.380s Main at org.chromium.chrome.browser.TabsTest.testIncognitoTabsNotRestoredAfterSwipe(TabsTest.java:1671) C 18.380s Main at java.lang.reflect.Method.invokeNative(Native Method) C 18.380s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 18.380s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 18.380s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 18.380s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726) C 18.380s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 18.380s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 18.380s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 18.380s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 18.380s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:556) C 18.380s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1705) Please provide any additional information below. Attach a screenshot if possible. Extremely high repro rate on a Kindle Fire HD (3rd Generation). Can conceptually reproduce on any device though.
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60fb2a58f8d53e033f22722c5b41142de7a733b9 commit 60fb2a58f8d53e033f22722c5b41142de7a733b9 Author: kraush <kraush@amazon.com> Date: Fri Sep 23 16:35:00 2016 Wait for async file creation in TabsTest File creation of tab states is done in an async fashion. TabsTest should correspondingly use a polling mechanism to verify files are actually being created. BUG=649429 Review-Url: https://codereview.chromium.org/2362793002 Cr-Commit-Position: refs/heads/master@{#420628} [modify] https://crrev.com/60fb2a58f8d53e033f22722c5b41142de7a733b9/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
,
Jul 26 2017
This test has started flaking a fair bit again recently, despite the fix above and the @RetryOnFailure annotation, see test history at org.chromium.chrome.browser.TabsTest#testIncognitoTabsNotRestoredAfterSwipe e.g. from https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/14156 java.lang.AssertionError at org.chromium.base.process_launcher.ChildConnectionAllocator.removeListener(ChildConnectionAllocator.java:304) at org.chromium.content.browser.ChildProcessLauncherHelper$6$1.run(ChildProcessLauncherHelper.java:388) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at android.os.Looper.loop(Looper.java:148) at android.os.HandlerThread.run(HandlerThread.java:61) (other tests in that class are also somewhat flaky but this one seems particularly bad)
,
Jul 26 2017
,
Jul 27 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/947f479a4b2a663901aded3d06c617abc759c829 commit 947f479a4b2a663901aded3d06c617abc759c829 Author: Alexandre Elias <aelias@chromium.org> Date: Fri Jul 28 01:51:37 2017 Disable flaky testIncognitoTabsNotRestoredAfterSwipe. This test has been flaking even with RetryOnFailure, so disable it. NOTRY=true TBR=yfriedman BUG=649429 Change-Id: I71bdcb520cc158dc11192fdf3d75ab90bd6d179b Reviewed-on: https://chromium-review.googlesource.com/590989 Reviewed-by: Alexandre Elias <aelias@chromium.org> Commit-Queue: Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/heads/master@{#490195} [modify] https://crrev.com/947f479a4b2a663901aded3d06c617abc759c829/chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java
,
Jul 28 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by kra...@amazon.com
, Sep 22 2016