Consolidate "Learn More" text link styles |
|||||||
Issue descriptionExpected for all touch points default: #3367D6, no underline hover: #3367D6, no underline, hand cursor ----- Touch points ----- Device, touchpad (subpage) - Learn more Privacy and security - web services - Site settings subpages* - Clear browsing data dialog Languages and input (dropdown) - Learn more Google Cloud print (subpage) - Learn more Manage a11y features (subpage) - Learn more Reset (dialog) - Learn more - View reported settings Powerwash (dialog) - Learn more *Each sites settings sub-subpage seems to be using 'Learn More' diffferently, i.e. as an explanation for the entire page. A more preferred UI is a (?) at the subpage header level. Filed at crbug.com/649430
,
Sep 23 2016
,
Sep 26 2016
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd4e4f2ac263da7271469dc282f8608fd6712df8 commit bd4e4f2ac263da7271469dc282f8608fd6712df8 Author: dmazzoni <dmazzoni@chromium.org> Date: Wed Sep 28 23:34:24 2016 Fix style issues with MD accessibility page Fix subheading style by using h2 instead of h3 (it has the correct style by default now). Add 16px space before settings-dropdown-menu inside of a list-item. Update text link style based on bug 649427 (should this be in settings_shared_css.html or is this fine for now?) BUG= 649421 , 649431 , 649427 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2373713004 Cr-Commit-Position: refs/heads/master@{#421681} [modify] https://crrev.com/bd4e4f2ac263da7271469dc282f8608fd6712df8/chrome/browser/resources/settings/a11y_page/manage_a11y_page.html [modify] https://crrev.com/bd4e4f2ac263da7271469dc282f8608fd6712df8/chrome/browser/resources/settings/settings_shared_css.html
,
Nov 2 2016
,
Dec 13 2016
Any update? How can we help to ensure that these accessibility items are fixed for md-settings? Thanks!
,
Jan 7 2017
make sure to consult with hcarmona@ first about an accessible solution before changing everywhere
,
Jan 11 2017
,
Jan 11 2017
I checked the listed touch points and all but 2 of the learn-more/(?) buttons already have the specified style. Since the original bug report seems to be about consolidating style/visual presentation, I've made a CL to bring the 2 remaining outliers into place. In terms of accessibility, hcarmona@ instructed me to check whether or not the learn-more/(?) buttons are accessible via keyboard, and they all already are, so it doesn't seem like there's much to be changed. If I'm misunderstanding the point regarding accessibility, could you clarify chaok@/dbeam@?
,
Jan 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/861d6ea98b5b7a7c23b8c12ee6354a10411d86d4 commit 861d6ea98b5b7a7c23b8c12ee6354a10411d86d4 Author: scottchen <scottchen@chromium.org> Date: Thu Jan 12 18:36:33 2017 MD Settings: consolidate learn-more link styles BUG= 649427 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2628773004 Cr-Commit-Position: refs/heads/master@{#443298} [modify] https://crrev.com/861d6ea98b5b7a7c23b8c12ee6354a10411d86d4/chrome/browser/resources/settings/reset_page/powerwash_dialog.html [modify] https://crrev.com/861d6ea98b5b7a7c23b8c12ee6354a10411d86d4/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
,
Jan 12 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bettes@chromium.org
, Sep 22 2016