bookmark_utils on Android may add new bookmarks to the root node
Reported by
kra...@amazon.com,
Sep 22 2016
|
||
Issue descriptionChrome Version : Tip of master OS: Android (any version) What steps will reproduce the problem? 1. pm clear Chrome / Chromium to make sure you have no bookmarks 2. use bookmark_utils::AddIfNotBookmarked() to add a bookmark for google.com 3. Open the bookmark page What is the expected result? You can see the newly bookmarked google.com What happens instead? You don't see a bookmark for google.com Please provide any additional information below. Attach a screenshot if possible. If no bookmarks are found, bookmark_utils seems to attach all bookmarks to the "root" node, which is not visible by default on Android.
,
Oct 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4a5b95f057d9b29ee066225b43c89557b5c2691 commit c4a5b95f057d9b29ee066225b43c89557b5c2691 Author: kraush <kraush@amazon.com> Date: Wed Oct 12 15:56:37 2016 Always add bookmarks to the mobile node on Android bookmark_utils should always attach new bookmarks to the mobile node on Android, rather than the most recently used one. This is where the bookmark button already appends them to, and it will make sure all added bookmarks are visible. BUG= 649420 Review-Url: https://codereview.chromium.org/2367533003 Cr-Commit-Position: refs/heads/master@{#424751} [modify] https://crrev.com/c4a5b95f057d9b29ee066225b43c89557b5c2691/chrome/browser/ui/bookmarks/bookmark_utils_desktop.cc [modify] https://crrev.com/c4a5b95f057d9b29ee066225b43c89557b5c2691/components/bookmarks/browser/bookmark_model.cc [modify] https://crrev.com/c4a5b95f057d9b29ee066225b43c89557b5c2691/components/bookmarks/browser/bookmark_model.h [modify] https://crrev.com/c4a5b95f057d9b29ee066225b43c89557b5c2691/components/bookmarks/browser/bookmark_model_unittest.cc [modify] https://crrev.com/c4a5b95f057d9b29ee066225b43c89557b5c2691/components/bookmarks/browser/bookmark_utils.cc [modify] https://crrev.com/c4a5b95f057d9b29ee066225b43c89557b5c2691/components/bookmarks/browser/bookmark_utils.h
,
Feb 12 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by kra...@amazon.com
, Sep 22 2016