Flaky Clank IME and Text Selection tests |
||||
Issue description* ContentViewCoreSelectionTest#testSelectActionBarPlainTextCopy https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4436 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4257 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4260 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4267 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4288 * ImeTest#testContentEditableEvents_SetComposingText https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4438 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4436 * ImeTest#testImeNotShownOnLongPressingEmptyInput https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/4298
,
Sep 22 2016
,
Sep 22 2016
I'll write a patch to disable these now. The coverage is not crucial, and the appropriate folks are already assigned on investigating the flakiness in http://crbug.com/628964 and http://crbug.com/592428 .
,
Sep 22 2016
Issue 649474 has been merged into this issue.
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/611dec311f31ead13d9c8648febc34dad1409c38 commit 611dec311f31ead13d9c8648febc34dad1409c38 Author: aelias <aelias@chromium.org> Date: Thu Sep 22 23:39:49 2016 Disable flaky Android IME and selection tests. These tests (*all* Selection tests, and a few of the IME tests) are extremely flaky to the point that they often cause waterfall redness despite @RetryOnFailure. These areas are actively owned (amaralp@ owns Android selection, and changwan@/yabinh@ own Android IME) and we plan to circle back to reenable without @RetryOnFailure when they have been fully deflaked. The @FlakyTest annotation is deprecated so also replace existing uses of it with @DisabledTest, and secondly don't comment out the other annotations which seems to be unnecessary nowadays. BUG= 649411 , 628964 , 592428 Review-Url: https://codereview.chromium.org/2362013002 Cr-Commit-Position: refs/heads/master@{#420502} [modify] https://crrev.com/611dec311f31ead13d9c8648febc34dad1409c38/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java [modify] https://crrev.com/611dec311f31ead13d9c8648febc34dad1409c38/content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java
,
Sep 23 2016
Fixing root cause and reenabling tracked in other bugs.
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59e3a9e0896916dee88888a692d1f2a4c94d3102 commit 59e3a9e0896916dee88888a692d1f2a4c94d3102 Author: aelias <aelias@chromium.org> Date: Fri Sep 23 22:59:37 2016 Actually disable testSelectionPreservedAfterReshown. I made a text editing mistake in http://crrev.com/2362013002 and only removed @RetryOnFailure for this particular test without adding @DisabledTest as intended, thus actually increasing bot redness. TBR=boliu NOTRY=true BUG= 649411 , 592428 Review-Url: https://codereview.chromium.org/2360333005 Cr-Commit-Position: refs/heads/master@{#420767} [modify] https://crrev.com/59e3a9e0896916dee88888a692d1f2a4c94d3102/content/public/android/javatests/src/org/chromium/content/browser/ContentViewCoreSelectionTest.java |
||||
►
Sign in to add a comment |
||||
Comment 1 by boliu@chromium.org
, Sep 22 2016