Refactor histogram_macros.h |
||
Issue descriptionhistogram_macros.h is quite messy. We should refactor it to have seperate files for LOCAL_ macros, as well as hide internal macro details as much as possible. We should also improve the inline documentation, make it easier to generate histograms when macros are not an option, and a other cleanup related tasks.
,
Sep 28 2016
,
Oct 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c83caef73ee8be2d2068c3aff34a11e6d515c44 commit 7c83caef73ee8be2d2068c3aff34a11e6d515c44 Author: rkaplow <rkaplow@chromium.org> Date: Tue Oct 04 22:37:55 2016 Add a basic exact linear macro. Ends up being the same as enum, but making it explicit will make our API more understandable, as a user shouldn't need to know the detail that enum is actually just 0-1, 1-2, etc. Also adding mpearson@ and I as owners BUG= 649410 Review-Url: https://codereview.chromium.org/2385053003 Cr-Commit-Position: refs/heads/master@{#422971} [modify] https://crrev.com/7c83caef73ee8be2d2068c3aff34a11e6d515c44/base/metrics/OWNERS [modify] https://crrev.com/7c83caef73ee8be2d2068c3aff34a11e6d515c44/base/metrics/histogram_macros.h |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 27 2016