New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649405 link

Starred by 8 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

generate a notification when logging into CrOS w/modified flags

Project Member Reported by vapier@chromium.org, Sep 22 2016

Issue description

if you modify flags in chrome://flags, CrOS will restart Chrome automatically when you log in (and same when you log out).  this adds a noticeable delay (and black screen) to the process.

the chrome://flags page already has a Warning section, but people often skip over or disregard that when the flag they're looking for is a "safe" one.  either way, they don't associate it with the delayed/black login, or they forget about it completely (they made the change a while ago but only just now restarted).

i've seen reports of this at least once a month from Googlers/developers, so i imagine the non-Googler hit rate is even higher.

what if we threw up a notification upon login when we had to restart chrome due to changed flags ?  it could have text explaining the delay/restart and take them to chrome://flags upon clicking to reset things if they wanted.  it could be similar to the notification we issue atm when you press shift+esc:
- it'd show up in the notification tray area in the bottom right
- auto hide/disappear after like 20 seconds
- user can dismiss it like any other notification
- still be in the tray if they want to recall it
 
I like this idea.
Labels: -Pri-3 Pri-2
Owner: kuscher@chromium.org
Status: Assigned (was: Untriaged)
This makes a lot of sense.

kuscher@ any thoughts on a PM owner?
Components: UI>Shell>Shelf
Labels: M-56
Owner: zalcorn@chromium.org
I agree. This would be useful. I nominate Zach to push this through our launch process since he hasn't had a few small bugs to push through :)
Labels: PM-zalcorn
On it :)
How does "Experimental flags caused Chrome OS to reboot. To prevent this, reset all flags to default." sound as notification text?

Comment 6 by vapier@chromium.org, Sep 30 2016

i think "Chrome OS to reboot" is confusing to the user.  they just booted the device ... why would it be rebooted ?

how about:
"Experimental flags cause Chrome to restart itself when logging in and out. To prevent this, reset all flags to default."
I just uploaded the assets for the icon.
Please let me know if you have any questions.

https://drive.google.com/open?id=0B_2Uyb2Rhx2OYkpDNHUwako4VHc
experiemental_flag_200.svg
1.7 KB Download
experiemental_flag_100.svg
1.6 KB Download
Screen Shot 2016-10-24 at 4.34.37 PM.png
26.5 KB View Download
Thanks Elizabeth. Can we make the text "Experimental flags caused Chrome to restart during login. To prevent this, reset all flags to default." so that it's more clear what caused the notification to fire.

Also, I don't think we need the title text, as it's repeated at the start of the sentence. WDYT?
Cc: abodenha@chromium.org
+Albert, who's the right person to add this feature? I'll get a launch bug set up.
Here is how it looks with title removed.
Screen Shot 2016-10-24 at 4.34.37 PM.png
26.5 KB View Download
Labels: -M-56 M-57
Elizabeth, that image still has the title, could you upload one that doesn't have it?
Components: -UI>OSIntegration Internals>PlatformIntegration
Deprecating UI>OSIntegration in favor of the more generic Internals>PlatformIntegration
+1 for this notification idea.

There's a multitude of topics in Chromebook Central on this issue -
https://productforums.google.com/forum/#!topicsearchin/chromebook-central/black$20screen$20after$20login$20-sleep

#CBC-RS/TC-watchlist
Cc: st...@chromium.org elizabethchiu@chromium.org
Labels: -M-57 M-58
steel@: think someone could implement this in 58?
elizabethchiu@: could you provide a link to a mock with no title and the text from Comment #8 and I'll send it to UI review?
zalcorn@ Here is the mock with no title. Please let me know if you need anything else. 

https://improv.googleplex.com/projects/ahtzfmdvb2dsZS5jb206aW1wcm92LXNlcnZpY2VyEAsSB1Byb2plY3QY0Z-XPAw/files/ahtzfmdvb2dsZS5jb206aW1wcm92LXNlcnZpY2VyJQsSCkNvbGxlY3Rpb24YgICA4NeClAkMCxIIUmVzb3VyY2UYAQw
Screen Shot 2017-01-19 at 6.20.53 PM.png
95.6 KB View Download

Comment 16 by st...@chromium.org, Jan 20 2017

Cc: -st...@chromium.org zalcorn@chromium.org
Owner: st...@chromium.org
Assigning to myself to find an owner.

Comment 17 by st...@chromium.org, Jan 20 2017

Cc: michae...@chromium.org jdufault@chromium.org

Comment 18 by st...@chromium.org, Jan 23 2017

Owner: jdufault@chromium.org
Jake, this isn't a super high priority - but if you get any spare cycles, could you pick this up?

Comment 19 by st...@chromium.org, Jan 23 2017

Owner: wzang@chromium.org
After speaking to Jake, this seems like a pretty ideal first bug.
Assigning to Colin who is interested in picking it up.

Comment 20 by wzang@chromium.org, Jan 27 2017

Cc: -abodenha@chromium.org -vapier@chromium.org -michae...@chromium.org -jdufault@chromium.org st...@chromium.org
After discussion with Rahul, we want the notification to show up after normal login as well as after crash / restart, so this will serve as a reminder to the user that some flags are not in the default state, instead of just being an explanation for the black screen. Please suggest on the following notification text, thanks:

Some experimental flags are not in the default state, please proceed with caution. Click for more information.

Upon clicking it will direct to chrome://flags

Besides, do we want the notification to stay intentionally longer than default? 
Hmm, not sure I agree with that change. We are specifically trying to be an explanation of the black screen as it is a non-obvious side effect of flags (where as most other effects are more directly related to the flag's function).

UI review is currently churning on this so we'll see what they say after a bit more back and forth.

Comment 22 by wzang@chromium.org, Jan 30 2017

I'm work on creating two notifications and we can further discuss which one to keep (or keep both). One is the specific explanation triggered only after unexpected black screen. The other is the general reminder of the existence of non-default flags which will show up after every login / restart. It can be repetitive but on the other hand, it helps users to realize some unexpected behavior can be due to the non-default flags.  

Comment 23 by willg...@gmail.com, Jan 30 2017

Would it not be easier and less intrusive to modify the Chrome://flags warning text?

Comment 24 by st...@chromium.org, Jan 30 2017

Colin, let's break this up into two bugs.
One for the notification on login, one for notification on crash.

The latter can be taken up at a later time once UI is done with their churn.

Comment 25 by wzang@chromium.org, Jan 30 2017

Rahul, just to clarify, for this bug we want a one-time notification after Chrome restart upon login, after setting flags?

Comment 26 by st...@chromium.org, Jan 30 2017

AFAICT, from the original description, we should show a notification on every login - as long as special flags are being used.

To clarify - let's show this any time Chrome restarts upon login because flags are set.

Comment 28 by wzang@chromium.org, Jan 30 2017

OK, I see.

Comment 29 by st...@chromium.org, Jan 30 2017

If custom flags are set, Chrome will always restart. Hence, this will end up showing every single time.

Following UI review, here's a mock with the notification design and text.
When pressed, the notification action should reset all flags to default, but not restart the device - the change will take effect on next user reboot.
Let me know if you have questions!
flags.png
50.6 KB View Download

Comment 31 Deleted

Here are the icons in both 1x and 2x.
experimental-flag_1x.svg
1.4 KB Download
experimental-flag_2x.svg
1.6 KB Download
Cc: -elizabethchiu@chromium.org -st...@chromium.org
Zach, can you name an existing notification with a similar design? (i.e. starts with ChromeOS system, and has image on the right), so that I can do something similar in terms of implementation. I already created a notification but it looks more like the mock Elizabeth sent earlier.
Cc: mitsuji@chromium.org
The screenshot shows the notification design update that is coming along with the NYC rebase, so I believe if our new notification is structured the same way as existing notifications it should be good to go.
+Hiro to confirm.
My NYC N notification PRD is here: go/arc-n-notifications


Zach, after discussing with Rahul and Alexander, we realized 'TURN OFF FEATURES' might not help with the black screen, because regular users cannot reset the flags which the owner set, so the user may still see black screen even after clicking the button and have more confusion. What do you think?

Comment 37 by wzang@chromium.org, Feb 13 2017

Cc: st...@chromium.org alemate@chromium.org
Cc: r...@chromium.org
Cc: -st...@chromium.org

Comment 40 by r...@chromium.org, Mar 27 2017

Labels: -M-58 M-60

Comment 41 by wzang@chromium.org, Mar 27 2017

zalcorn@ The CL is ready but it is blocked on the help page (as explanation of experimental flags and black screen). 
Issue 681278 has been merged into this issue.
Labels: Not-Touch-Friendly-Launcher
Labels: Hotlist-ConOps-CrOS
(Bulk Edit) Adding the new conops Chrome OS hotlist to all open issues with the "#CBC-RS/TC-watchlist" tag, our former tracking tag.
Labels: -M-60

Sign in to add a comment