generate a notification when logging into CrOS w/modified flags |
||||||||||||||||||||||
Issue descriptionif you modify flags in chrome://flags, CrOS will restart Chrome automatically when you log in (and same when you log out). this adds a noticeable delay (and black screen) to the process. the chrome://flags page already has a Warning section, but people often skip over or disregard that when the flag they're looking for is a "safe" one. either way, they don't associate it with the delayed/black login, or they forget about it completely (they made the change a while ago but only just now restarted). i've seen reports of this at least once a month from Googlers/developers, so i imagine the non-Googler hit rate is even higher. what if we threw up a notification upon login when we had to restart chrome due to changed flags ? it could have text explaining the delay/restart and take them to chrome://flags upon clicking to reset things if they wanted. it could be similar to the notification we issue atm when you press shift+esc: - it'd show up in the notification tray area in the bottom right - auto hide/disappear after like 20 seconds - user can dismiss it like any other notification - still be in the tray if they want to recall it
,
Sep 27 2016
This makes a lot of sense. kuscher@ any thoughts on a PM owner?
,
Sep 28 2016
I agree. This would be useful. I nominate Zach to push this through our launch process since he hasn't had a few small bugs to push through :)
,
Sep 29 2016
,
Sep 30 2016
On it :) How does "Experimental flags caused Chrome OS to reboot. To prevent this, reset all flags to default." sound as notification text?
,
Sep 30 2016
i think "Chrome OS to reboot" is confusing to the user. they just booted the device ... why would it be rebooted ? how about: "Experimental flags cause Chrome to restart itself when logging in and out. To prevent this, reset all flags to default."
,
Oct 24 2016
I just uploaded the assets for the icon. Please let me know if you have any questions. https://drive.google.com/open?id=0B_2Uyb2Rhx2OYkpDNHUwako4VHc
,
Oct 25 2016
Thanks Elizabeth. Can we make the text "Experimental flags caused Chrome to restart during login. To prevent this, reset all flags to default." so that it's more clear what caused the notification to fire. Also, I don't think we need the title text, as it's repeated at the start of the sentence. WDYT?
,
Oct 25 2016
+Albert, who's the right person to add this feature? I'll get a launch bug set up.
,
Oct 25 2016
Here is how it looks with title removed.
,
Nov 28 2016
Elizabeth, that image still has the title, could you upload one that doesn't have it?
,
Jan 2 2017
Deprecating UI>OSIntegration in favor of the more generic Internals>PlatformIntegration
,
Jan 19 2017
+1 for this notification idea. There's a multitude of topics in Chromebook Central on this issue - https://productforums.google.com/forum/#!topicsearchin/chromebook-central/black$20screen$20after$20login$20-sleep #CBC-RS/TC-watchlist
,
Jan 20 2017
steel@: think someone could implement this in 58? elizabethchiu@: could you provide a link to a mock with no title and the text from Comment #8 and I'll send it to UI review?
,
Jan 20 2017
zalcorn@ Here is the mock with no title. Please let me know if you need anything else. https://improv.googleplex.com/projects/ahtzfmdvb2dsZS5jb206aW1wcm92LXNlcnZpY2VyEAsSB1Byb2plY3QY0Z-XPAw/files/ahtzfmdvb2dsZS5jb206aW1wcm92LXNlcnZpY2VyJQsSCkNvbGxlY3Rpb24YgICA4NeClAkMCxIIUmVzb3VyY2UYAQw
,
Jan 20 2017
Assigning to myself to find an owner.
,
Jan 20 2017
,
Jan 23 2017
Jake, this isn't a super high priority - but if you get any spare cycles, could you pick this up?
,
Jan 23 2017
After speaking to Jake, this seems like a pretty ideal first bug. Assigning to Colin who is interested in picking it up.
,
Jan 27 2017
After discussion with Rahul, we want the notification to show up after normal login as well as after crash / restart, so this will serve as a reminder to the user that some flags are not in the default state, instead of just being an explanation for the black screen. Please suggest on the following notification text, thanks: Some experimental flags are not in the default state, please proceed with caution. Click for more information. Upon clicking it will direct to chrome://flags Besides, do we want the notification to stay intentionally longer than default?
,
Jan 29 2017
Hmm, not sure I agree with that change. We are specifically trying to be an explanation of the black screen as it is a non-obvious side effect of flags (where as most other effects are more directly related to the flag's function). UI review is currently churning on this so we'll see what they say after a bit more back and forth.
,
Jan 30 2017
I'm work on creating two notifications and we can further discuss which one to keep (or keep both). One is the specific explanation triggered only after unexpected black screen. The other is the general reminder of the existence of non-default flags which will show up after every login / restart. It can be repetitive but on the other hand, it helps users to realize some unexpected behavior can be due to the non-default flags.
,
Jan 30 2017
Would it not be easier and less intrusive to modify the Chrome://flags warning text?
,
Jan 30 2017
Colin, let's break this up into two bugs. One for the notification on login, one for notification on crash. The latter can be taken up at a later time once UI is done with their churn.
,
Jan 30 2017
Rahul, just to clarify, for this bug we want a one-time notification after Chrome restart upon login, after setting flags?
,
Jan 30 2017
AFAICT, from the original description, we should show a notification on every login - as long as special flags are being used.
,
Jan 30 2017
To clarify - let's show this any time Chrome restarts upon login because flags are set.
,
Jan 30 2017
OK, I see.
,
Jan 30 2017
If custom flags are set, Chrome will always restart. Hence, this will end up showing every single time.
,
Feb 4 2017
Following UI review, here's a mock with the notification design and text. When pressed, the notification action should reset all flags to default, but not restart the device - the change will take effect on next user reboot. Let me know if you have questions!
,
Feb 4 2017
Here are the icons in both 1x and 2x.
,
Feb 6 2017
Zach, can you name an existing notification with a similar design? (i.e. starts with ChromeOS system, and has image on the right), so that I can do something similar in terms of implementation. I already created a notification but it looks more like the mock Elizabeth sent earlier.
,
Feb 6 2017
The screenshot shows the notification design update that is coming along with the NYC rebase, so I believe if our new notification is structured the same way as existing notifications it should be good to go. +Hiro to confirm.
,
Feb 6 2017
My NYC N notification PRD is here: go/arc-n-notifications
,
Feb 8 2017
Zach, after discussing with Rahul and Alexander, we realized 'TURN OFF FEATURES' might not help with the black screen, because regular users cannot reset the flags which the owner set, so the user may still see black screen even after clicking the button and have more confusion. What do you think?
,
Feb 13 2017
,
Mar 3 2017
,
Mar 3 2017
,
Mar 27 2017
,
Mar 27 2017
zalcorn@ The CL is ready but it is blocked on the help page (as explanation of experimental flags and black screen).
,
Apr 7 2017
Issue 681278 has been merged into this issue.
,
Nov 29 2017
,
Jun 4 2018
(Bulk Edit) Adding the new conops Chrome OS hotlist to all open issues with the "#CBC-RS/TC-watchlist" tag, our former tracking tag.
,
Dec 26
|
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by semenzato@chromium.org
, Sep 22 2016