New issue
Advanced search Search tips

Issue 649403 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Add test for verifying timeout behaviour of the `push` event

Project Member Reported by peter@chromium.org, Sep 22 2016

Issue description

When the `push` event times out, it should finish the event after a predetermined amount of time. This currently will be five minutes, but might become less per  Issue 646783 . The rest of the Push system should behave as if no notification was shown.

An example where this would happen is as follows:

  self.addEventListener('push', e => e.waitUntil(new Promise()));
 
Owner: harkness@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/641c3b9629668ad19be1ee9ba8936624ce364bfa

commit 641c3b9629668ad19be1ee9ba8936624ce364bfa
Author: harkness <harkness@chromium.org>
Date: Fri Dec 02 13:32:24 2016

Added a local tick clock to ServiceWorkerVersion.

As part of testing for functionality that uses StartRequestWithCustomTimout,
a way to trigger the timeout was needed on ServiceWorkerVersion. This CL
adds a clock that can be overridden by testing. It also updates the
ServiceWorker version tests to test multiple entries in the timeout request
queue and that they time out in the correct order.

BUG= 649403 

Review-Url: https://codereview.chromium.org/2504663002
Cr-Commit-Position: refs/heads/master@{#435929}

[modify] https://crrev.com/641c3b9629668ad19be1ee9ba8936624ce364bfa/content/browser/service_worker/service_worker_version.cc
[modify] https://crrev.com/641c3b9629668ad19be1ee9ba8936624ce364bfa/content/browser/service_worker/service_worker_version.h
[modify] https://crrev.com/641c3b9629668ad19be1ee9ba8936624ce364bfa/content/browser/service_worker/service_worker_version_unittest.cc

Comment 3 by peter@chromium.org, Jun 28 2017

Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)

Comment 4 by peter@chromium.org, Jun 30 2017

Status: Archived (was: Available)
We might get to 

Sign in to add a comment