New issue
Advanced search Search tips

Issue 649400 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 761767



Sign in to add a comment

min_width for ColumnSet::AddColumn is ignored

Project Member Reported by vasi...@chromium.org, Sep 22 2016

Issue description

Version: 55.0.2869.0
OS: Linux

Create a ColumnSet:

views::ColumnSet* column_set = layout->AddColumnSet(column_set_id);

column_set->AddColumn(views::GridLayout::FILL,
                      views::GridLayout::FILL,
                      1,
                      views::GridLayout::USE_PREF,
                      0,
                      kMinUsernameSize);

column_set->AddColumn(views::GridLayout::FILL,
                      views::GridLayout::FILL,
                      1,
                      views::GridLayout::USE_PREF,
                      0,
                      0);

Put a long text into the second column. The first column will basically disappear despite |kMinUsernameSize| was specified. It's used only if there is enough space. 
 

Comment 1 by sky@chromium.org, Sep 22 2016

Indeed. DistributeDelta doesn't deal well with a delta < 0. By that I mean it assumes the resize percent can be applied equally to each element. That isn't necessarily the case.
bookmark.0
2.4 KB Download
If this isn't a bug then what's the usecase for setting the minimal width?

Comment 4 by sky@chromium.org, Sep 28 2016

I'm not sure what you mean. This is a bug, that's why I filed it.

Comment 5 by pbos@chromium.org, Oct 11 2017

Cc: bsep@chromium.org
Owner: pbos@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by pbos@chromium.org, Oct 11 2017

Blocking: 761767

Comment 7 by pbos@chromium.org, Oct 11 2017

Owner: sky@chromium.org

Comment 8 by sky@chromium.org, Oct 12 2017

Status: Started (was: Assigned)

Comment 9 by sky@chromium.org, Oct 13 2017

Status: Fixed (was: Started)
This was fixed at https://chromium.googlesource.com/chromium/src.git/+/eaeea6e5e051d6467a4f58e355c229d1094791a0 . But you have to opt into the new behavior. I filed 774633 to make the new behavior the default.

Sign in to add a comment