New issue
Advanced search Search tips

Issue 649399 link

Starred by 2 users
Status: Fixed
Owner:
mustaq@chromium.org
Closed: Sep 2016
Cc:
nzolghadr@chromium.org
dtapu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 508283



Sign in to add a comment

PlatformMouseWheelEvent should be a subclass of PlatformMouseEvent

Project Member Reported by mustaq@chromium.org, Sep 22 2016 
WebMouseWheelEvent instances uses only a few fields of WebMouseEvent---this is expected since WebMouseWheelEvent is not really a pointer event. We have a stronger example a bit downstream: PlatformWheelEvent doesn't inherit from PlatformMouseEvent.

It seems the only fields from WebMouseEvent that is useful for WebMouseWheelEvent is x & y.

Comment 1 by mustaq@chromium.org, Sep 27 2016

Summary: PlatformMouseWheelEvent should be a subclass of PlatformMouseEvent (was: WebMouseWheelEvent shouldn't be a subclass of WebMouseEvent)
Since DOM wheel events are subclass of mouse events, we will refactor the platform layer instead to match.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ead89c0689ca05e34e09fb0087d574b823f12f5

commit 9ead89c0689ca05e34e09fb0087d574b823f12f5
Author: mustaq <mustaq@chromium.org>
Date: Wed Sep 28 20:50:18 2016

Made PlatformWheelEvent a subclass of PlatformMouseEvent.

This makes the class hierarchy same for Platform & Web wheel events.

BUG= 649399 

Review-Url: https://codereview.chromium.org/2377703002
Cr-Commit-Position: refs/heads/master@{#421636}

[modify] https://crrev.com/9ead89c0689ca05e34e09fb0087d574b823f12f5/third_party/WebKit/Source/platform/PlatformMouseEvent.h
[modify] https://crrev.com/9ead89c0689ca05e34e09fb0087d574b823f12f5/third_party/WebKit/Source/platform/PlatformWheelEvent.h

Comment 3 by mustaq@chromium.org, Sep 28 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment