Issue 649389 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ bzanotti@chromium.org Last visit > 30 days ago
Closed:	Sep 2016
Components:	Services>SignIn
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	3
Type:	Bug
M-55

Add unit tests for SigninHeaderHelper

Project Member Reported by bzanotti@chromium.org, Sep 22 2016

Issue description

The logic to add or not (and the content) the Mirror header/cookie has gotten more complex over time, but we still don't have any tests coverage.

We should fix this, especially since a bug could break Mirror or send the header/cookie to wrong domains.

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c2ec6ccadd007b2066c8ec575ed346e659cd471

commit 1c2ec6ccadd007b2066c8ec575ed346e659cd471
Author: bzanotti <bzanotti@chromium.org>
Date: Fri Sep 23 16:43:21 2016

Add unit tests for Signin Header Helpers.

BUG= 649389 

Review-Url: https://codereview.chromium.org/2360733002
Cr-Commit-Position: refs/heads/master@{#420634}

[modify] https://crrev.com/1c2ec6ccadd007b2066c8ec575ed346e659cd471/components/signin/core/browser/BUILD.gn
[add] https://crrev.com/1c2ec6ccadd007b2066c8ec575ed346e659cd471/components/signin/core/browser/signin_header_helper_unittest.cc

Comment 2 by bzanotti@chromium.org, Sep 23 2016

Status: Fixed (was: Started)

►

Issue 649389 link

Issue metadata

Add unit tests for SigninHeaderHelper

Issue description

Comment 1 by bugdroid1@chromium.org, Sep 23 2016

Comment 1 Deleted

Comment 2 by bzanotti@chromium.org, Sep 23 2016

Comment 2 Deleted

Sign in to add a comment