New issue
Advanced search Search tips

Issue 649376 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 679794



Sign in to add a comment

tangentialPressure and twist should be added to IDLs

Project Member Reported by dtapu...@chromium.org, Sep 22 2016

Issue description

Even though tangentialPressure is not available and will be reported as 0 for now.

tangentialPressure should appear in the PointerEventInit and PointerEvent idls.

Spec change: https://github.com/w3c/pointerevents/commit/efe7d4f6b891a2a3f53112ca9d7b262462465c2d


 

Comment 1 by mustaq@chromium.org, Sep 22 2016

Labels: OS-All
Summary: tangentialPressure and twist should be added to IDLs (was: tangentialPressure should be added to IDLs)
Same applies to the twist field.

Comment 2 by lanwei@chromium.org, Oct 27 2016

Cc: lanwei@chromium.org

Comment 3 by rbyers@chromium.org, Dec 16 2016

Cc: nzolghadr@chromium.org
 Issue 657579  has been merged into this issue.

Comment 4 by rbyers@chromium.org, Dec 16 2016

IMHO we should probably add this only when hooking it up on at least one platform.  IIRC we had some hardware/OS combination which supported these (was it the Wacom on Mac perhaps?).

I agree it's not very high priority, but perhaps it's pretty easy to do and so still worth doing soon?  Navid, do you want to mark this Available to see if anyone else is interested in picking it up?
Owner: lanwei@chromium.org
This is something that Lan will be working on I believe. I believe there was another similar issue for this that was assigned to her anyway. I assigned this to her for now.

Comment 6 by lanwei@chromium.org, Dec 16 2016

Status: Started (was: Assigned)

Comment 7 by mustaq@chromium.org, Dec 20 2016

 Issue 657580  has been merged into this issue.

Comment 8 by lanwei@chromium.org, Jan 10 2017

Blocking: 679794
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dcc9534ac96ac852f430c6c76b0c2f8521d851ae

commit dcc9534ac96ac852f430c6c76b0c2f8521d851ae
Author: lanwei <lanwei@chromium.org>
Date: Thu Jan 19 18:28:28 2017

Add tangentialPressure and twist properties to PointerEvent on Mac

Set the properties of tangentialPressure and twist for WebMouseEvent of stylus type,
which is created from NSEvent in WebMouseEventBuilder::Build.

Intent to implement and ship: PointerEvent.tangentialPressure and PointerEvent.twist:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-NmHZqP4cQg

BUG= 649376 

Review-Url: https://codereview.chromium.org/2587393004
Cr-Commit-Position: refs/heads/master@{#444792}

[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/content/browser/renderer_host/input/web_input_event_builders_mac.mm
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/external/wpt/pointerevents/idlharness-expected.txt
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_constructor.html
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor-expected.txt
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/fast/events/constructors/pointer-event-constructor.html
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/Source/core/events/PointerEvent.cpp
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/Source/core/events/PointerEvent.h
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/Source/core/events/PointerEvent.idl
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/Source/core/events/PointerEventFactory.cpp
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/Source/core/events/PointerEventInit.idl
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/Source/web/WebInputEvent.cpp
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/third_party/WebKit/public/platform/WebPointerProperties.h
[modify] https://crrev.com/dcc9534ac96ac852f430c6c76b0c2f8521d851ae/ui/events/blink/web_input_event_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Jan 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f10eb68d3cdc96ce8543ee307899b147fa0632

commit 19f10eb68d3cdc96ce8543ee307899b147fa0632
Author: lanwei <lanwei@chromium.org>
Date: Fri Jan 27 01:27:27 2017

Add tangentialPressure and twist properties to PointerEvent on Windows

We have added the properties of tangentialPressure and twist to WebMouseEvent for stylus type,
now we are adding them to PointerDetails in ui::MouseEvent.

BUG= 649376 

Review-Url: https://codereview.chromium.org/2647253002
Cr-Commit-Position: refs/heads/master@{#446523}

[modify] https://crrev.com/19f10eb68d3cdc96ce8543ee307899b147fa0632/ui/aura/gestures/gesture_recognizer_unittest.cc
[modify] https://crrev.com/19f10eb68d3cdc96ce8543ee307899b147fa0632/ui/events/blink/web_input_event.cc
[modify] https://crrev.com/19f10eb68d3cdc96ce8543ee307899b147fa0632/ui/events/blink/web_input_event_unittest.cc
[modify] https://crrev.com/19f10eb68d3cdc96ce8543ee307899b147fa0632/ui/events/event.h
[modify] https://crrev.com/19f10eb68d3cdc96ce8543ee307899b147fa0632/ui/events/event_unittest.cc

Can this be marked as fixed now?
Status: Fixed (was: Started)
We also possibly add 'twist' in Android, using MotionEvent.AXIS_RZ values. But we should wait until we have devices reporting it.

Let's close this bug, we will open another when needed for Android.

Sign in to add a comment