New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649375 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

crosperf: Error in colortrans replacement code, causes crosperf to fail.

Project Member Reported by cmt...@chromium.org, Sep 22 2016

Issue description

I updated my sources, ran crosperf with page_cycler, and it failed in the new colortrans replacement code:

$ ./crosperf/crosperf --rerun=True --json_report=True lumpy.exp --logging_level=verbose

...
Traceback (most recent call last):
  File "./crosperf/crosperf.py", line 128, in <module>
    Main(sys.argv)
  File "./crosperf/crosperf.py", line 124, in Main
    runner.Run()
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/crosperf/experiment_runner.py", line 286, in Run
    self._PrintTable(self._experiment)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/crosperf/experiment_runner.py", line 213, in _PrintTable
    self.l.LogOutput(TextResultsReport.FromExperiment(experiment).GetReport())
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/crosperf/results_report.py", line 324, in GetReport
    summary_table = _PrintTable(self.GetSummaryTables(perf=False), output_type)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/crosperf/results_report.py", line 268, in _PrintTable
    return ''.join(printer.Print() for printer in printers)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/crosperf/results_report.py", line 268, in <genexpr>
    return ''.join(printer.Print() for printer in printers)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/cros_utils/tabulator.py", line 1039, in Print
    return self._GetStringValue()
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/cros_utils/tabulator.py", line 1121, in _GetStringValue
    out = self._GetCellValue(i, j)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/cros_utils/tabulator.py", line 1047, in _GetCellValue
    p, s = self._GetColorFix(cell.color)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/cros_utils/tabulator.py", line 1019, in _GetColorFix
    prefix = misc.rgb2short(color.r, color.g, color.b)
  File "/usr/local/google/home/cmtice/work/toolchain-utils-6/cros_utils/misc.py", line 568, in rgb2short
    return greencolor[g/50]
IndexError: list index out of range


I am attaching the experiment file I used.
 
lumpy.exp
1.1 KB Download
Status: Verified (was: Untriaged)

Sign in to add a comment