Strange behavior around user pod focus and submit button |
|||||
Issue descriptionVersion: 55.0.2858.0 OS: chrome What steps will reproduce the problem? (1) Get to user pod login screen with multiple accounts (2) Enter a password in Pod 1, then TAB or click focus onto Pod 2, then back to Pod 1 What is the expected output? Either Pod 1's password is still there, or the Submit arrow button is disabled (grey) What do you see instead? Pod 1's entered password is gone, but the Submit button is still active (blue) I don't know if erasing a typed but unsubmitted password when a pod loses focus is intended or not. If it's not, that's the bug; if it is, the button shouldn't be active when the password field is empty. Also noticed: if you TAB focus onto a pod's upper right menu button, moving the mouse anywhere moves focus back to the pod's password field. This *seems* like a bug (mouse movement doesn't usually change focus), but wanted to confirm with UI expert. If so, this can be spun off into a separate issue. Both these issues are minor and relatively harmless.
,
Sep 23 2016
glevin@ - Yeah this big was caused by my work. I will look into it.
,
Sep 23 2016
Just noticed another very minor oddity regarding the Submit button, this time on the lock screen. The TAB order goes: Password > Pod menu button > Shut down > Sign out > Submit button > System tray > Notifications That seems like a weird place for the Submit button in the TAB order. It seems (to me) like it should come right after the Password field, or maybe not be a TAB stop at all (I can't think of a use case where I'd want to TAB onto it before pressing ENTER to activate it). I'd check with the UX folks, confirm that this is a bug, and then maybe file separately.
,
Sep 23 2016
I think there's no need for a TAB since ENTER on the password input submits the password. I put the two of these on the same CL since they're tiny changes and CC'd you.
,
Sep 23 2016
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2d5de21399173d1048ddb1fc7320d191b4b63769 commit 2d5de21399173d1048ddb1fc7320d191b4b63769 Author: sammiequon <sammiequon@chromium.org> Date: Fri Sep 23 18:16:03 2016 cros: Minor issues regarding submit button and tabbing on user pod fixed. Previously, when multiple user pods are present, tabbing out of oneresets the password, but the submit button is not disabled. Also the submit button was being tabbed into after the header bar; removed tabbing for submit button since enter key does the same thing. BUG= 649370 TEST=none Review-Url: https://codereview.chromium.org/2365943002 Cr-Commit-Position: refs/heads/master@{#420665} [modify] https://crrev.com/2d5de21399173d1048ddb1fc7320d191b4b63769/ui/login/account_picker/user_pod_row.js [modify] https://crrev.com/2d5de21399173d1048ddb1fc7320d191b4b63769/ui/login/account_picker/user_pod_template.html
,
Sep 23 2016
,
Oct 7 2016
,
Oct 12 2016
Verified on ChromeOS 8872.6.0 / 55.0.2883.7 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by glevin@chromium.org
, Sep 22 2016Status: Assigned (was: Available)