Harmony - manage e-mail links dialog's radio buttons show border when hovered over |
|||
Issue descriptionVersion: 55.0.2867.0 OS: 10.12 What steps will reproduce the problem? (1) Log into Gmail (2) Click the "manage links"(?) icon (I'm not sure if this only appears if you've set Gmail to open e-mail links, or if this icon always appears) (3) Mouse over the radio buttons What is the expected output? Radio buttons should not change their appearance What do you see instead? When mousing over a radio button, the button displays a rectangular border
,
Sep 22 2016
This is the LabelButton mouseover animation, which we need to get rid of altogether, I think...?
,
Sep 22 2016
Yes.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b9fd5ef2fb2722e3d6d60531622715b186492c0 commit 8b9fd5ef2fb2722e3d6d60531622715b186492c0 Author: ellyjones <ellyjones@chromium.org> Date: Tue Sep 27 13:21:52 2016 views: remove PlatformStyle::CreateLabelButtonBorder This function was doing the wrong thing on Mac, so it has been removed and the default implementation simply inlined into LabelButton. BUG= 649367 Review-Url: https://codereview.chromium.org/2358913006 Cr-Commit-Position: refs/heads/master@{#421188} [modify] https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0/ui/views/BUILD.gn [modify] https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0/ui/views/controls/button/label_button.cc [delete] https://crrev.com/44584978d3ba8c7e7c14aab6d10e28b65b91dba6/ui/views/style/mac/dialog_button_border_mac.cc [delete] https://crrev.com/44584978d3ba8c7e7c14aab6d10e28b65b91dba6/ui/views/style/mac/dialog_button_border_mac.h [delete] https://crrev.com/44584978d3ba8c7e7c14aab6d10e28b65b91dba6/ui/views/style/mac/dialog_button_border_mac_unittest.cc [modify] https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0/ui/views/style/platform_style.cc [modify] https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0/ui/views/style/platform_style.h [modify] https://crrev.com/8b9fd5ef2fb2722e3d6d60531622715b186492c0/ui/views/style/platform_style_mac.mm
,
Sep 27 2016
,
Sep 27 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ellyjo...@chromium.org
, Sep 22 2016