Write mojom and StructTraits for DisplaySnapshot |
||||||||||||
Issue descriptionIn order to convert Ozone GBM to use Mojo IPC we will need a mojom and StructTraits for DisplaySnapshot (and likely a new DisplaySnapshot implementation). DisplaySnapshots need to be sent from the gpu process to the mus-ws process for Ozone GBM. This would be similar to the DisplaySnapshotProxy and corresponding Chrome IPC code: https://cs.chromium.org/chromium/src/ui/ozone/common/display_snapshot_proxy.h https://cs.chromium.org/chromium/src/ui/ozone/common/gpu/ozone_gpu_messages.h
,
Sep 24 2016
It seems this is largely a manual process. I don't want to do anything silly, so if there's a tool to automate part or all of the conversion please let me know. Need to add at least 3 mojom's under ui/display/types/mojo/ for: display_constants.mojom (for enum DisplayConnectionType) display_mode.mojom (for struct DisplayMode) display_snapshot.mojom (for struct DisplaySnapshot)
,
Sep 25 2016
I think it's mostly manual. I suggest there be a ui/display/mojom directory for these. ui/gfx/geometry/mojo is probably a good example to look at. rockot@ or yzhen@ (CC'ed here) are the best people for specific mojo questions. Mojo has been evolving rapidly so it's always worth asking.
,
Sep 27 2016
rockot@ or yzhen@ -- I tried to follow ui/gfx/geometry/mojo to write mojom for //ui/display/types/display_*.h but got some presubmit warnings: ** Presubmit ERRORS ** Do not introduce new mojom targets with use_new_wrapper_types set to false. The mode is deprecated and will be removed soon. ui/display/mojo/BUILD.gn What is this deal with deprecating use_new_wrapper_types? Thanks.
,
Sep 27 2016
We just haven't gotten around to porting existing uses away from the old wrappers There's no good reason to use them for new targets.
,
Oct 6 2016
,
Oct 6 2016
,
Dec 9 2016
hshi@ how is this coming?
,
Dec 9 2016
re:#8 not much progress, I'm afraid, this is still in my backburner.
,
Jan 13 2017
,
Jan 19 2017
,
Jan 19 2017
Thanh is going to take a look at this.
,
Jan 25 2017
,
Mar 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e29136a35e8282ad38b3504915837eb26425918c commit e29136a35e8282ad38b3504915837eb26425918c Author: thanhph <thanhph@chromium.org> Date: Wed Mar 08 16:24:46 2017 Write mojoms and StructTraits for DisplaySnapshot. We need to enable communication between the mus window server and mus gpu in the new split architecture of window server and gpu. DisplaySnapShot is abstract so DisplaySnapshotMojo is created to support mojom serialization/deserialization. Enum mojom and struct traits are also added for DisplayConnectionType. BUG= 649366 Review-Url: https://codereview.chromium.org/2646213002 Cr-Commit-Position: refs/heads/master@{#455466} [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/BUILD.gn [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/display_snapshot_mojo.cc [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/display_snapshot_mojo.h [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/BUILD.gn [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_constants.mojom [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_constants.typemap [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_constants_struct_traits.cc [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_constants_struct_traits.h [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_mode.typemap [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_mode_struct_traits.cc [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_mode_struct_traits.h [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_snapshot_mojo.mojom [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_snapshot_mojo.typemap [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_snapshot_mojo_struct_traits.cc [add] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_snapshot_mojo_struct_traits.h [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_struct_traits_test.mojom [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/display_struct_traits_unittest.cc [modify] https://crrev.com/e29136a35e8282ad38b3504915837eb26425918c/ui/display/mojo/typemaps.gni
,
Mar 8 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
,
Feb 26 2018
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by h...@chromium.org
, Sep 23 2016