New issue
Advanced search Search tips

Issue 649355 link

Starred by 4 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Views: Border / shadow artifacts on origin info bubble

Project Member Reported by rsesek@chromium.org, Sep 22 2016 
Version: 55.0.2868.0
OS: macOS 10.11.6

What steps will reproduce the problem?
(1) --secondary-ui-md --top-chrome-md=material-hybrid --enable-features=MacViewsNativeDialogs,MacViewsWebUIDialogs
(2) Open the origin info bubble by clicking on the lock icon
(3) Observe the bottom left and right corners

What is the expected output?
No weird border artifacts

What do you see instead?
Weird border artifacts

Please use labels and text to provide additional information.
Screen Shot 2016-09-22 at 11.12.44 AM.png
92.8 KB View Download

Comment 1 by tapted@chromium.org, Sep 23 2016

Owner: karandeepb@chromium.org
Status: Assigned (was: Untriaged)
karan - can you take a look?

I suspect the CL that removed the arrow didn't update the logic that calculates the window mask. (which means hit-testing on the border is probably broken on other platforms, even if it's not resulting in drawing glitches).

Comment 2 by karandeepb@chromium.org, Sep 26 2016

Labels: OS-Linux
Owner: est...@chromium.org
The window mask is only used on OSX 10.9 for generating the shadows. So don't think that's the problem. I tested this, and it's also a problem on Linux. I think it has to do with the changes in https://crrev.com/2343913003. Assigning to estade@.

Comment 3 by karandeepb@chromium.org, Sep 26 2016

Labels: -Proj-MacViews
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8be177f507ce4abbb43fbc537e81f96a2219783

commit b8be177f507ce4abbb43fbc537e81f96a2219783
Author: estade <estade@chromium.org>
Date: Tue Sep 27 18:09:22 2016

Harmony - fix border for OIB.

This bug only appears for the certain bubbles because it is only
visually apparent when the margins are set to zero. I'm not sure
why we're setting this extra background. It's probably my fault.

BUG= 649355 

Review-Url: https://codereview.chromium.org/2363403003
Cr-Commit-Position: refs/heads/master@{#421267}

[modify] https://crrev.com/b8be177f507ce4abbb43fbc537e81f96a2219783/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/b8be177f507ce4abbb43fbc537e81f96a2219783/ui/views/bubble/bubble_dialog_delegate.cc

Comment 5 by est...@chromium.org, Sep 28 2016

Status: Fixed (was: Assigned)
Summary: Views: Border / shadow artifacts on origin info bubble (was: MacViews: Border / shadow artifacts on origin info bubble)
►

Sign in to add a comment