New issue
Advanced search Search tips

Issue 649339 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 677001
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Determine usefulness of inserting dummy zlib header

Project Member Reported by xunji...@chromium.org, Sep 22 2016

Issue description

When decoding deflate stream fails, we insert a dummy gzip header and try again.

This looks like a workaround that might not be applicable anymore. We should add histograms and see if we can remove this.

---------------------------------------------------------
  if (decoding_mode_ == DECODE_MODE_DEFLATE && status == Filter::FILTER_ERROR) {
    // As noted in Mozilla implementation, some servers such as Apache with
    // mod_deflate don't generate zlib headers.
    // See 677409 for instances where this work around is needed.
    // Insert a dummy zlib header and try again.
    if (InsertZlibHeader()) {
      *dest_len = dest_orig_size;
      status = DoInflate(dest_buffer, dest_len);
    }
  }
---------------------------------------------------------
 

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by mmenke@chromium.org, Sep 22 2016

Summary: Determine usefulness of inserting dummy zlib header (was: Determine usefulness of inserting dummy gzip header)
Cc: mmenke@chromium.org
Mergedinto: 677001
Status: Duplicate (was: Available)
 Issue 677001  shows that the workaround is still needed. mmenke@ has a CL to update the workaround and restrict it to deflate stream. Marking this as a dup of the more recent bug.

Sign in to add a comment