Issue metadata
Sign in to add a comment
|
Regression: Tabstrip broken on Linux Ubuntu 14.04 on resuming from full screen with specific gpu |
||||||||||||||||||||||
Issue descriptionVersion: 55.0.2868.0 OS: Linux Ubuntu 14.4 What steps will reproduce the problem? (1) Launch chrome and go to full screen using F11. (2) Resume from the full screen using F11 and observe the tabstrip. What is the expected output? > Tabstrip should be rendered fine. What do you see instead? > Tabstrip is completely broken. Please use labels and text to provide additional information. > This is regression issue broken in M-54 and is specific to the attached gpu. Last good build: 54.0.2799.0 First bad build: 54.0.2800.0 Note: The bisect set up is in progress on the Linux system where the issue is reproducible. Will update the narrow tool bisect soon.
,
Sep 22 2016
Are you still trying to bisect on the affected machine? Maybe you can try the fancy new bisect_builds.py which gets it down to one cl?
,
Sep 23 2016
>#2 The issue is reproducible only on, one of the Non-corp machine where the new bisect script doesn't work as of now. The above mentioned manual good and bad is incorrect as the issue is seen on 54.0.2799.0 as well on the 2nd launch of chrome. Rebisected and below is the bisect info: Last good build: 54.0.2793.0 First bad build: 54.0.2794.0 Changelog: https://chromium.googlesource.com/chromium/src/+log/a408d3aea3e7f270266fbf5e483a5b2e708ae553..ccfd78962de023613e2e281b392fdc9982718136 Suspecting: https://chromium.googlesource.com/chromium/src/+/35ec773b64c07f58b0e59377d917f6424edda189 to be the related change. cwallez@: Could you please take a look at this. Thank you!
,
Sep 23 2016
Thanks for the report, the disable_partial_swap workaround is not enabled when it should. Does changing gl_renderer to gl_version in the following line fix it for you? https://cs.chromium.org/chromium/src/gpu/config/gpu_driver_bug_list_json.cc?q=driver_bug_list_json&sq=package:chromium&l=516
,
Sep 26 2016
Reply to comment #4: TE do not have the commit access to make code change and get it tested as per requested in #4. cwallez@ will it be possible for you please confirm the behavior? ajha@ ,Please attach chrome://gpu information. FYI: This is a regression in M54 & marked as a stable blocker. We're looking to ship that very soon, so please try to have this bug fixed no later than first week of October so that it can be merged to branch 2840 ASAP.
,
Sep 26 2016
ligimole@ it is difficult to test locally as these happen on open-source drivers that are close to impossible to install on our workstations. The provided GpuBrokenTabstrip contains the chrome://gpu info. Fix is in the CQ (99% sure it will fix it, but I don't have a nouveau driver install to test it on). https://codereview.chromium.org/2373513002/
,
Sep 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d88c53039fadac470fe52e938588a259e7dcbacd commit d88c53039fadac470fe52e938588a259e7dcbacd Author: cwallez <cwallez@chromium.org> Date: Mon Sep 26 22:34:41 2016 gpu/config: disable partial swaps on Mesa Gallium drivers too. Previously detection of Mesa drivers was done by matching "Mesa" in GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL hardware database have it in GL_VERSION. BUG= 649296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2373513002 Cr-Commit-Position: refs/heads/master@{#421021} [modify] https://crrev.com/d88c53039fadac470fe52e938588a259e7dcbacd/gpu/config/gpu_control_list.cc [modify] https://crrev.com/d88c53039fadac470fe52e938588a259e7dcbacd/gpu/config/gpu_control_list.h [modify] https://crrev.com/d88c53039fadac470fe52e938588a259e7dcbacd/gpu/config/gpu_driver_bug_list_json.cc
,
Sep 26 2016
ajha@ can you confirm this commits fixes the problem?
,
Sep 27 2016
Verified the issue on the latest M-55(55.0.2873.0) on Linux Ubuntu 14.04 and on the system with the attached gpu in C#0. This is working as intended. Hence adding the verified label.
,
Sep 27 2016
Thanks for the fix, please request a merge to M54 ASAP.
,
Sep 27 2016
,
Sep 27 2016
Approving for M54 for today's Beta
,
Sep 27 2016
This was merged in https://codereview.chromium.org/2374783002/ (thanks Ken!)
,
Sep 27 2016
If there is no pending work in M54, please remove - Merge-Approved-54 label.
,
Sep 27 2016
,
Sep 27 2016
,
Sep 28 2016
Rechecked this on chrome version 54.0.2840.41 on Ubuntu 14.04. Merge is working as intended. Adding TE-Verified labels.
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754 commit c0b7e65a4e3d1ca3c57b129dc78364ae9688c754 Author: cwallez <cwallez@chromium.org> Date: Tue Sep 27 20:25:55 2016 gpu/config: disable partial swaps on Mesa Gallium drivers too. Previously detection t diff HEADof Mesa drivers was done by matching "Mesa" in GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL hardware database have it in GL_VERSION. TBR=kbr@chromium.org BUG= 649296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2374783002 Cr-Commit-Position: refs/branch-heads/2840@{#550} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754/gpu/config/gpu_control_list.cc [modify] https://crrev.com/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754/gpu/config/gpu_control_list.h [modify] https://crrev.com/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754/gpu/config/gpu_driver_bug_list_json.cc
,
Sep 28 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754 commit c0b7e65a4e3d1ca3c57b129dc78364ae9688c754 Author: cwallez <cwallez@chromium.org> Date: Tue Sep 27 20:25:55 2016 gpu/config: disable partial swaps on Mesa Gallium drivers too. Previously detection t diff HEADof Mesa drivers was done by matching "Mesa" in GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL hardware database have it in GL_VERSION. TBR=kbr@chromium.org BUG= 649296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2374783002 Cr-Commit-Position: refs/branch-heads/2840@{#550} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754/gpu/config/gpu_control_list.cc [modify] https://crrev.com/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754/gpu/config/gpu_control_list.h [modify] https://crrev.com/c0b7e65a4e3d1ca3c57b129dc78364ae9688c754/gpu/config/gpu_driver_bug_list_json.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ajha@chromium.org
, Sep 22 2016Summary: Regression: Tabstrip broken on Linux Ubuntu 14.04 on resuming from full screen with specific gpu (was: Regression: Tabstrip broken on Linux Ubuntu 14.04 on resuming from full screen)