Computed style values that use parentNode are wrong for Shadow DOM |
||||||||||||
Issue descriptionex. https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp?sq=package:chromium&l=2145 if (style.minHeight().isAuto()) { Node* parent = styledNode->parentNode(); if (isFlexOrGrid(parent ? parent->ensureComputedStyle() : nullptr)) return CSSPrimitiveValue::createIdentifier(CSSValueAuto); return zoomAdjustedPixelValue(0, style); } return zoomAdjustedPixelValueForLength(style.minHeight(), style); that doesn't work if you've been slotted somewhere, your parentStyle doesn't come from the parentNode(), it comes from your insertion point.
,
Sep 23 2016
I think @cbiesinger should know more about this.
,
Sep 23 2016
The spec is https://drafts.csswg.org/css-flexbox/#min-size-auto "On a flex item whose overflow is visible in the main axis, when specified on the flex item’s main-axis min-size property, specifies an automatic minimum size. It otherwise computes to 0 (unless otherwise defined by a future specification)." So our implementation is actually too simplistic but it does need to know if it's a flex item (or, grid item)
,
Sep 29 2016
,
Oct 12 2016
,
Feb 13 2017
,
Feb 17 2017
We should use FlatTreeTraversal::parent() here, from where parentStyle comes.
,
Mar 30 2017
,
Mar 30 2017
,
Oct 30 2017
,
Oct 31 2017
,
Dec 6 2017
,
Dec 6
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
The implementation for the mentioned instance in the report now checks if its layout object is a flex or grid item. No access to parentNode(). Could not see any suspicious use of parentNode() in css/ or style/ now. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by timloh@chromium.org
, Sep 23 2016Status: Available (was: Untriaged)