New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649276 link

Starred by 2 users
Status: Verified
Owner:
dpa...@chromium.org
Closed: Nov 2016
Cc:
nyerramilli@chromium.org
dpa...@chromium.org
michae...@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MD Settings] Browser does not navigate to page according omnibox URL after search action.

Reported by rk...@etouch.net, Sep 22 2016 
Chrome Version:55.0.2868.0 (Official Build) b22235a16193be6cfa6e199a5c7a2427a7b505e6-refs/heads/master@{#420217}
OS: Windows(7,8,10)

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings page.
(2) Search something on page, then click on 'Main menu' and navigate to 'Download' section under 'Advanced'.
(3) Clear search field and then click on back navigation button, observe page and omnibox URL.

Actual: Browser does not navigated to page according omnibox URL.

Expected: Browser should navigate to page according omnibox URL.

This is a regression issue, broken in 'M-55', will soon update the other info:

Good Build: 55.0.2847.0
Bad Build: 55.0.2849.0
Actual_Navigation.mp4
1.2 MB View Download
Expected_Navigation.mp4
1.3 MB View Download

Comment 1 by msrchandra@chromium.org, Sep 22 2016

Labels: ReleaseBlock-Stable hasbisect-per-revision OS-Linux OS-Mac
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2847.0 (Revision: 416149).
Bad build: 55.0.2849.0 (Revision: 416454).

You are probably looking for a change made after 416385 (known good), but no later than 416386 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/63d027126b56e97d2d1d8f955af5d65547a11eb1..776eb73066021f12a815c669c73c4db433751d15


From the CL above, assigning the issue to the concern owner --
@tommycli -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Issue is also seen on Mac and Linux also.
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 2 by ajha@chromium.org, Sep 28 2016 

tommycli@: Could you please take a look at this and help in further investigation.

Comment 3 by ajha@chromium.org, Oct 3 2016 

Cc'ing michaelpg@ as well for more inputs on this.

Comment 4 by ajha@chromium.org, Oct 10 2016 

Issue is still reproducible on the latest M-55 on chrome version: 55.0.2883.6.

Comment 5 by ajha@chromium.org, Oct 14 2016

Cc: michae...@chromium.org

Comment 6 by michae...@chromium.org, Oct 18 2016

Cc: dpa...@chromium.org
Labels: -ReleaseBlock-Stable OS-Chrome
Generally, we intentionally do not scroll on forward/back events. Getting
the ideal behavior for that would likely not be worth the time.

I think the bigger issue is that navigating to a section after searching does not work unless the section is part of the results.

Working case:
  1. Search for "download". Privacy and Downloads display.
  2. Open the nav menu and click Downloads. Scrolls the Downloads
     section to top.

Broken case:
  1. Search for "spell". Privacy and Languages display.
  2. Open the nav menu and click Downloads. Nothing happens.

What is the expected behavior here? My instinct is that navigating from the menu should always clear the search, then navigate (even if a section is shown as a search result).

Back button behavior is less concerning to me, but I filed  issue 657150  for that. These bugs may end up merging depending on what behavior we want.

Comment 7 by dpa...@chromium.org, Oct 18 2016

Labels: Proj-MaterialDesign-WebUI

Comment 8 by tommycli@chromium.org, Oct 25 2016

Owner: dpa...@chromium.org
assigning to dpapad, because he has a WIP patch that fixes this (incidentally)

Comment 9 by dpa...@chromium.org, Oct 25 2016

Labels: Hotlist-MD-Settings-SearchBox

Comment 10 by dpa...@chromium.org, Nov 9 2016

Status: Fixed (was: Assigned)
Fixed by https://codereview.chromium.org/2449663002.

Comment 11 by rookrishna@chromium.org, Dec 21 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment