Unexpected pause when lockscreen during background playback |
|||||||||||
Issue description1. Navigate to youtube.com, play some video 2. Press home button, the video should pause 3. Resume the video through media notification 4. Lockscreen Observed: Background video playback is paused after 4 Reproducible in latest dev (M55)
,
Sep 22 2016
Yes, pretty consistently, feel free to come and check it out.
,
Sep 22 2016
It's reproducible on dailymotion.com and your autoplay test page (http://mounirlamouri.github.io/sandbox/autoplay/test.html) Also found some weird behavior for vine.com. Will file another bug.
,
Sep 22 2016
Bumping to P1 for avayvod@ to investigate. zqzhang@ and miguelg@, can you reproduce this on M54?
,
Sep 22 2016
I can't reproduce on M54.
,
Sep 22 2016
,
Sep 22 2016
Something to keep in mind: some changes happened in M55 that just got merged in M54. If these changes are the cause of the breakage, it might break M54 later.
,
Sep 22 2016
I am also unable to repro in 54. For now at least. Can you ping this when the potentially problematic 54 makes it to beta?
,
Sep 22 2016
I'll try 54 branch head later today and see if it repros.
,
Sep 22 2016
Reproducible on 54.0.2840.35 (current M54 branch head).
,
Sep 22 2016
,
Sep 22 2016
I can't reproduce at https://project-1912052061267295165.firebaseapp.com/without-hack-timer.html. My mac's USB refuses to work today :/ I would suggest bisecting the Beta to find the offensive CL. IIRC, the change landed by Dale to fix the previous issue didn't have this problem when I tested so I doubt it is what's caused the problem. Re: #c2 it's a long walk.
,
Sep 22 2016
I'll do the bisect. Suspecting https://codereview.chromium.org/2308893002
,
Sep 22 2016
,
Sep 22 2016
sandersd@, can you PTAL :)
,
Sep 22 2016
The suspected CL is small and clearly more correct. However, it was part of a larger series of interdependent changes which may be related. A copy of the chrome://media-internals log during this behavior would be very helpful; I will attempt to reproduce and gather that.
,
Sep 22 2016
This is the pause timer firing, doesn't happen if you wait longer than 5 seconds between the background and resuming step. We need to invalidate the pause timer during play().
,
Sep 22 2016
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4619cd0ee861c0e15e0ed49e99f633f01b96fbdd commit 4619cd0ee861c0e15e0ed49e99f633f01b96fbdd Author: dalecurtis <dalecurtis@chromium.org> Date: Thu Sep 22 21:39:10 2016 Clear pause timer upon start of a playback. Otherwise this may nuke intentional playbacks from the media session. BUG= 649271 TEST=playback doesn't pause after 5 seconds if play occurs. Review-Url: https://codereview.chromium.org/2363813002 Cr-Commit-Position: refs/heads/master@{#420468} [modify] https://crrev.com/4619cd0ee861c0e15e0ed49e99f633f01b96fbdd/media/blink/webmediaplayer_impl.cc
,
Sep 23 2016
,
Sep 23 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276bb71f945600d1f6a287882588517d25f7282f commit 276bb71f945600d1f6a287882588517d25f7282f Author: Dale Curtis <dalecurtis@chromium.org> Date: Fri Sep 23 00:55:17 2016 Merge M54: "Clear pause timer upon start of a playback." Otherwise this may nuke intentional playbacks from the media session. BUG= 649271 TEST=playback doesn't pause after 5 seconds if play occurs. Review-Url: https://codereview.chromium.org/2363813002 Cr-Commit-Position: refs/heads/master@{#420468} (cherry picked from commit 4619cd0ee861c0e15e0ed49e99f633f01b96fbdd) Review URL: https://codereview.chromium.org/2367633002 . Cr-Commit-Position: refs/branch-heads/2840@{#506} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/276bb71f945600d1f6a287882588517d25f7282f/media/blink/webmediaplayer_impl.cc
,
Sep 23 2016
,
Sep 23 2016
Issue 649286 has been merged into this issue.
,
Sep 27 2016
Works as per expected behavior. Issue is verified on Latest M55 Build on trunk
,
Sep 28 2016
Works as per expected behavior. Issue is also verified on Latest M54 Beta Build
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276bb71f945600d1f6a287882588517d25f7282f commit 276bb71f945600d1f6a287882588517d25f7282f Author: Dale Curtis <dalecurtis@chromium.org> Date: Fri Sep 23 00:55:17 2016 Merge M54: "Clear pause timer upon start of a playback." Otherwise this may nuke intentional playbacks from the media session. BUG= 649271 TEST=playback doesn't pause after 5 seconds if play occurs. Review-Url: https://codereview.chromium.org/2363813002 Cr-Commit-Position: refs/heads/master@{#420468} (cherry picked from commit 4619cd0ee861c0e15e0ed49e99f633f01b96fbdd) Review URL: https://codereview.chromium.org/2367633002 . Cr-Commit-Position: refs/branch-heads/2840@{#506} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/276bb71f945600d1f6a287882588517d25f7282f/media/blink/webmediaplayer_impl.cc |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by mlamouri@chromium.org
, Sep 22 2016