New issue
Advanced search Search tips

Issue 649207 link

Starred by 1 user
Status: Fixed
Owner:
michae...@chromium.org
Closed: Sep 2016
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

cr-dialog body scrollbar doesn't span entire height

Project Member Reported by michae...@chromium.org, Sep 22 2016 
The body should use padding instead of margin to ensure that an overflow scrollbar is positioned as Alan wants it (stretches to the edges of the body's container).

<cr-dialog>s in Settings without a scrollbar look identical; when they have a scrollbar they look improved (see screenshots).
lang_before.png
49.3 KB View Download
lang_after.png
49.3 KB View Download
cbd1_before.png
68.1 KB View Download
cbd1_after.png
68.2 KB View Download
cbd2_before.png
62.1 KB View Download
cbd2_after.png
62.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b245b7d270fafab80c2eca0821a01165028b296d

commit b245b7d270fafab80c2eca0821a01165028b296d
Author: michaelpg <michaelpg@chromium.org>
Date: Thu Sep 22 08:35:53 2016

cr-dialog scrollbar should span entire body

Use padding instead of margin; see bug for screeshots.

BUG= 649207 
R=dpapad@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2365503003
Cr-Commit-Position: refs/heads/master@{#420283}

[modify] https://crrev.com/b245b7d270fafab80c2eca0821a01165028b296d/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/b245b7d270fafab80c2eca0821a01165028b296d/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/b245b7d270fafab80c2eca0821a01165028b296d/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 2 by dpa...@chromium.org, Sep 22 2016

Status: Fixed (was: Started)
I think this is fixed now.
►

Sign in to add a comment