New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649187 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocking:
issue 671375



Sign in to add a comment

MD Settings: About page missing "Set Up Automatic Updates ..." button.

Project Member Reported by dpa...@chromium.org, Sep 22 2016

Issue description

See screenshot and https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?l=8380,8399.

Per documentation in the link above, this is a Mac-only feature.
 
missing_button.png
255 KB View Download

Comment 1 by dpa...@chromium.org, Sep 22 2016

Cc: tbuck...@chromium.org dbeam@chromium.org bettes@chromium.org
@bettes: Where should the button reside in the new UI? Putting it next to the "Relaunch" button is an option, but I am afraid it will be very tight in terms of real estate (especially when considering non-English translations).
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
@dbeam: Should this be a dev blocker too?

Comment 4 by dpa...@chromium.org, Nov 19 2016

Cc: scottchen@chromium.org
While we're waiting for the design, I'll try to figure out how to code-wise add this button in the new Setting's page.
Labels: OS-Chrome
'Check for updates' button is missing on about page of chrome md settings

Comment 7 by dpa...@chromium.org, Nov 28 2016

@sdantuluri: Please file a separate issue for the bug you are observing and include a screenshot from the previous "about" (chrome://help) page that displays the button.

Comment 8 by dpa...@chromium.org, Nov 28 2016

Labels: -OS-Chrome
@bettes This is what I currently have, and it looks pretty crammed. How do you feel about putting the buttons in a dropdown menu?
Screen Shot 2016-11-29 at 2.23.22 PM.png
58.2 KB View Download
I guess we could also move the "set up automatic update" button as it's own line item, but it'll lose a bit of grouping context with version-related things.
Screen Shot 2016-11-29 at 2.31.33 PM.png
57.3 KB View Download
A problem with making the button its own line-item is - there's supposed to be a "visible but disabled" state, and I don't think we currently have a visible-but-disabled state for a settings-box line item.
Cc: -scottchen@chromium.org
Owner: scottchen@chromium.org
We should treat this as we do with 'default browser', by allowing for enabling within settings and keeping the setting visible but disabled when ON (which is not what we do today). The setting should sit on it's own line, as seen in the attachment. 

String changes: 
Off - Automatically update Chrome for all users. Learn more 
On - Automatic updates are turned on. Learn more

Learn more article: 
https://support.google.com/chrome/answer/95414?hl=en&vid=0-1091784683828-1480470694354

Mocks
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-About_Chrome.png%3Fz=width
Screen Shot 2016-11-29 at 6.05.37 PM.png
97.8 KB View Download
bettes@ few questions:

1) Hidden states:
Currently there are a few good reasons for the buttons to be hidden, such as being on a read-only filesystem, or if the process for some reason failed to register with the lower-level Google Keystone program etc. 
In other words, the user is not capable of doing autoupdate set-up regardless of the current set-up state. Should we keep the button hidden under these condition?

2) In-between states:
Currently, the button is visible-but-disabled WHILE it's checking/installing updates, or if the user is actually in the middle of setting up autoupdate already (i.e. they just clicked the button). In those cases, we'll need more strings to correctly indicate the states.

Comment 14 Deleted

Let me know if I understood this correctly. 

1.) If auto-update is not available on any particular setup or configuration, then I think it's okay to hide the button. 

2.) For the in-progress states that you're describing, we should just disable the button, but keep the string and right-facing arrow present. See the third example in the attachment. 
PREVIEW-About_Chrome.png
431 KB View Download
Cc: borisv@chromium.org

Comment 17 by dbeam@chromium.org, Dec 15 2016

Blocking: 671375
Labels: -Pri-2 Pri-1
Project Member

Comment 18 by bugdroid1@chromium.org, Dec 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2

commit 3109d3ea42d98c9f2831b96374b5a9cee68ab7d2
Author: dbeam <dbeam@chromium.org>
Date: Sun Dec 18 07:23:43 2016

Add mac-only "Set Up Automatic Updates..." button to the new about page.

A mac-only "Set Up Automatic Updates for All Users" button existed in
the old crome://help page, but was not ported over to the
chrome://md-settings/help page. This CL aims to port that button over.

By Scott Chen <scottchen@chromium.org> (http://crrev.com/2538013002)

BUG= 649187 
TBR=dpapad@chromium.org (LG'd on other CL)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2583743002
Cr-Commit-Position: refs/heads/master@{#439368}

[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/app/settings_strings.grdp
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/mac/keystone_glue.h
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/mac/keystone_glue.mm
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/resources/settings/about_page/about_page.html
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/resources/settings/about_page/about_page.js
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/resources/settings/about_page/about_page_browser_proxy.js
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/ui/webui/help/help_handler.cc
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/ui/webui/help/version_updater.h
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/ui/webui/help/version_updater_mac.mm
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/3109d3ea42d98c9f2831b96374b5a9cee68ab7d2/chrome/test/data/webui/settings/about_page_tests.js

Comment 19 by dbeam@chromium.org, Jan 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment