New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649185 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Single frame video playback is unreliable on sprout devices

Project Member Reported by w...@chromium.org, Sep 21 2016

Issue description

Originally discovered when MediaColorTests were failing on sprout devices.

To repro, play a single frame h264 video on a sprout device. Approximately half the time no frame is returned by the decoder.

I've confirmed that AVDA is queueing both the frame and EOS. It just never gets an output. There are no obvious differences between when it works and doesn't work.
 
what device were you using?  looking at the sprout team page, the only thing i get is "mediatek", of which i have none.

Comment 2 by w...@chromium.org, Sep 22 2016

Yeah it's a Mediatek one. I'll investigate more today. It seems like it's just a MediaCodec bug. Maybe timing related

Comment 3 by w...@chromium.org, Sep 22 2016

Owner: w...@chromium.org
Status: Started (was: Available)
Hmm. It's working reliably in a MediaCodec test app. AVDA is doing something weird :(

Comment 4 by w...@chromium.org, Oct 11 2016

The difference is in the test app we're configuring MediaCodec with the CSD (SPS and PPS). 
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18e1a10a685a93bbcd528da9d61387341fb8484b

commit 18e1a10a685a93bbcd528da9d61387341fb8484b
Author: watk <watk@chromium.org>
Date: Tue Oct 18 23:54:25 2016

Send the h264 SPS and PPS configuration parameters to AVDA

Previously we relied on MediaCodec's ability to get these from the
bitstream. But in at least one case (see bug) MediaCodec works more
reliably when we pass these when initializing it.

BUG= 649185 

Review-Url: https://codereview.chromium.org/2365103002
Cr-Commit-Position: refs/heads/master@{#426091}

[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/base/android/sdk_media_codec_bridge.cc
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/base/android/sdk_media_codec_bridge.h
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/base/android/sdk_media_codec_bridge_unittest.cc
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/filters/gpu_video_decoder.cc
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/gpu/android_video_decode_accelerator.cc
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/gpu/android_video_decode_accelerator.h
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/gpu/ipc/common/media_param_traits_macros.h
[modify] https://crrev.com/18e1a10a685a93bbcd528da9d61387341fb8484b/media/video/video_decode_accelerator.h

Comment 6 by w...@chromium.org, Nov 21 2016

Status: Fixed (was: Started)

Sign in to add a comment