Issue metadata
Sign in to add a comment
|
Wrong shelf icon are used on Chrome OS |
||||||||||||||||||||||||
Issue descriptionReproduced on samus. See attached screenshots. Pay attention to the lower-left corner -- many shelf icons are wrong. The orange exclamation mark icon is in fact "Chrome". Any idea what could have caused this? Note: this is with SimpleChrome and a local incremental build. It looks like the incorrect resource ID is used. I wonder if we're missing some build dependency.
,
Sep 22 2016
hshi, does it go away after a clean build? That would support a missing dependency. I don't see this on a linux desktop os=chromeos build at r420333 (nor have I seen it there any time this week). The only other thing I can think of is the deploy_chrome script not copying something we need, or a 100% vs. 200% resource pak problem. +stevenjb, did anything in deploy_chrome change recently?
,
Sep 22 2016
Yes, there was bug in deploy_chrome that has a fix pending which is likely the cause of this. Sadrul, can you mark this as fixed once that is in chromite and chromite for chrome has been rolled (I can help with that if you haven't done it recently)?
,
Sep 22 2016
I actually removed that part of the change from my CL since it wasn't clear what the fix should be: we seem to not want to unconditionally deploy the 2x resources, and the condition we depend on (having 'highdpi' in USE env variable) does not seem to work [anymore].
,
Sep 22 2016
OK, yeah, I just saw that. I see that the highdpi issue is still assigned to me. I will mark this as a dupe and continue the discussion there. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Sep 22 2016Components: -UI>Aura UI>Shell
Status: Untriaged (was: Available)