New issue
Advanced search Search tips

Issue 649182 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 644408
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Wrong shelf icon are used on Chrome OS

Project Member Reported by h...@chromium.org, Sep 21 2016

Issue description

Reproduced on samus. See attached screenshots.

Pay attention to the lower-left corner -- many shelf icons are wrong. The orange exclamation mark icon is in fact "Chrome". Any idea what could have caused this?

Note: this is with SimpleChrome and a local incremental build. It looks like the incorrect resource ID is used. I wonder if we're missing some build dependency.
 
Screenshot 2016-09-21 at 4.35.01 PM.png
196 KB View Download
Screenshot 2016-09-21 at 4.34.52 PM.png
45.2 KB View Download
IMG_20160921_163803.jpg
2.0 MB View Download
Cc: abodenha@chromium.org msw@chromium.org
Components: -UI>Aura UI>Shell
Status: Untriaged (was: Available)
That's pretty odd. The "shutdown" button at the login screen is webui. The shelf items are native views UI.

I agree it looks like a resource ID problem.

What revision of chrome are you on?


Comment 2 by h...@chromium.org, Sep 22 2016

re:#1 seems to have happened somewhere between r419000 and r419500
Cc: steve...@chromium.org
hshi, does it go away after a clean build? That would support a missing dependency.

I don't see this on a linux desktop os=chromeos build at r420333 (nor have I seen it there any time this week).

The only other thing I can think of is the deploy_chrome script not copying something we need, or a 100% vs. 200% resource pak problem.

+stevenjb, did anything in deploy_chrome change recently?
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
Yes, there was bug in deploy_chrome that has a fix pending which is likely the cause of this.

Sadrul, can you mark this as fixed once that is in chromite and chromite for chrome has been rolled (I can help with that if you haven't done it recently)?

Comment 5 by sadrul@chromium.org, Sep 22 2016

Cc: kylec...@chromium.org
I actually removed that part of the change from my CL since it wasn't clear what the fix should be: we seem to not want to unconditionally deploy the 2x resources, and the condition we depend on (having 'highdpi' in USE env variable) does not seem to work [anymore].
Mergedinto: 644408
Owner: steve...@chromium.org
Status: Duplicate (was: Assigned)
OK, yeah, I just saw that. I see that the highdpi issue is still assigned to me. I will mark this as a dupe and continue the discussion there.

Sign in to add a comment