cpu_time_percentage not being emitted for run_benchmark |
||||
Issue descriptioncommand: tools/perf/run_benchmark --browser=canary --also-run-disabled-tests --reset-results --output-format=html2 battor.trivial_pages See attached image. However, it works fine with ./bin/run_dev_server when I load any trace.
,
Sep 21 2016
I tried substituting in systemHealthMetrics as the metric under the battor benchmark, and got:
"""
[ RUN ] /var/folders/pm/q_gmk1r17pj_rnnc9vv4k7g0003db3/T/tmpJdyYwY.html
MapFunctionError: Cannot read property 'buildFromEvents' of undefined
at Object.longTasksMetric (/tracing/metrics/system_health/long_tasks_metric.html:93:41)
at new systemHealthMetrics (/tracing/metrics/system_health/system_health_metrics.html:21:19)
at runMetrics (/Users/erikchen/projects/chromium/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:37:14)
at metricMapFunction (/Users/erikchen/projects/chromium/src/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:71:18)
at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:41:7)
at eval (/Users/erikchen/projects/chromium/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:26:10)
at mapSingleTraceWithResult (/Users/erikchen/projects/chromium/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
at Object.mapSingleTraceMain (/Users/erikchen/projects/chromium/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:76:18)
at eval (/Users/erikchen/projects/chromium/src/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:89:15)
"""
Looks like a lot of this code is never used by benchmarks?
,
Sep 22 2016
,
Sep 22 2016
Sorry, to clarify, I fixed the longTasksMetric bug described in comment 2. I have not investigated why cpu_time_percentage is empty from telemetry.
,
Sep 22 2016
Erik: can you try open the results2.html file in TOT chrome? I found out that I had same problem with metric side panel, but only on beta-Chrome
,
Sep 22 2016
cpuDuration is not guaranteed to be a number on all slices. https://codereview.chromium.org/2356253005 In lthi_cats, the slice whose title is"RendererMain.START_MSG_LOOP" and category is "ETW Trace Event" has cpuDuration = undefined. In javascript, any number plus undefined yields NaN. When cpuTimeMetric calls addSample(NaN), the Histogram says numNans++ but can't increment the count of any bin. There is a summary statistic "nans", but it defaults to off, so the histogram looks totally empty.
,
Sep 29 2016
erikchen: is this fixed?
,
Sep 29 2016
yes
,
Sep 29 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by nedngu...@google.com
, Sep 21 2016Labels: -Pri-3 Pri-1
Owner: benjhayden@chromium.org
Status: Assigned (was: Untriaged)