New issue
Advanced search Search tips

Issue 649164 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Support right-aligning or auto-resizing Shiny Modern MenuItemView

Project Member Reported by lgar...@chromium.org, Sep 21 2016

Issue description

Splitting out from https://bugs.chromium.org/p/chromium/issues/detail?id=512442#c83

We need this for Page Info in M-55.
ellyjones@, who would be good to implement either of these?
 
Summary: Support right-aligning or auto-resizing Shiny Modern MenuItemView (was: Support right-aligning or resizing Shiny Modern MenuItemView)
Retitling to be more specific.

"Resizing" in this case would mean resizing to the selected value, like views::MenuButton.
I think we are going to disable the MacViews experiment in a couple of days, which will likely make this bug obsolete, but on the off-chance that we don't, I can implement this. I'll own this bug in the meantime.
I still see MacViews on Canary, which has the lovely property of sizing a combobox on an option that cannot be selected.

What's the latest state on MacViews / Shiny Modern?
Screen Shot 2016-10-13 at 15.48.57.png
787 KB View Download
MacViews has been disabled on canary/dev since September 23. The screenshot attached in #3 looks like Windows 10 to me.
Sorry, I attached the wrong screenshot in the last comment.

This is how Chrome Canary looks for me right now.
Screen Shot 2016-10-14 at 14.27.28.png
505 KB View Download
Ah, it seems that user profile was set to an explicit flag from a recent bug fix.

What's the future of MacViews, though?
MacViews will not ship for any dialogs within the next month or so, at least. Right now we're working on a new cross-platform UI style, so whatever happens, this bug won't be Mac-specific.
Components: UI>Browser>Omnibox>PageInfo
Blocking: -512442
Labels: -Pri-2 Pri-3
Labels: -M-55
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Labels: -Hotlist-PageInfo
Labels: Hotlist-EnamelAndFriendsFixIt
Cc: ellyjo...@chromium.org
Owner: est...@chromium.org
These do resize right now, which is good. They do not support right alignment.

estark@, do you know if these are meant to be right-aligned? If so we can implement that, but it will probably look fairly strange since other comboboxes don't do that. If you do want these right-aligned, please assign this bug back to me and I'll implement :)
Cc: patricia...@chromium.org
ellyjones: could you give a litte more context? Which comboboxes are you referring to? The drop-downs in Page Info? And which alignment are you referring to? The text inside each combobox? 

I hope patricialor can help answer this question :) 
Cc: est...@chromium.org
Owner: maxwalker@chromium.org
I think Elly must be talking about the text inside the comboboxes, since the comboboxes themselves are definitely right-aligned. It's hard to tell from maxwalker@'s mocks as to whether they are supposed to be or not since the "Allow" and "Block" English strings are pretty similar length.

maxwalker@, could you clarify on whether we want the strings inside the comboboxes to be right-aligned?
+ patricialor

This is the behavior we landed on to make sure the menus line up as well as possible:

The final combobox width will try to fit all the currently shown strings in, except for strings exceeding a maximum threshold. If the user changes the currently selected item in a combobox to a longer string (that is still under the threshold), it'll resize to fit and show inconsistent widths, but will not resize all other comboboxes to that width until the bubble is closed and re-opened.
Page Info.png
81.0 KB View Download
RE #c18, I think Elly was asking about whether the strings inside the comboboxes should be right aligned, not the combobox widths. E.g. if "Allow" should be right-aligned in the combobox.
Got it, sorry. The text inside the combobox should be left-aligned like in all other comboboxes. It should be right-aligned only for RTL languages. I added a note to the specs (https://goo.gl/eCFDVk).
Status: WontFix (was: Assigned)
Thanks for your input Max! Closing this then since everything is WAI.

Sign in to add a comment