New issue
Advanced search Search tips

Issue 649159 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

imported/wpt/shadow-dom/slotchange-event.html is failing

Project Member Reported by nzolghadr@chromium.org, Sep 21 2016

Issue description

After the latest wpt rebase
imported/wpt/shadow-dom/slotchange-event.html

is failing. I marked it as failure for now in TestExpecatation.
 
Components: Blink>WebComponents
Owner: hayato@chromium.org

Comment 2 by tkent@chromium.org, Sep 23 2016

Components: -Blink>DOM
Status: Assigned (was: Untriaged)

Comment 4 by hayato@chromium.org, Oct 12 2016

Components: -Blink>WebComponents Blink>DOM>ShadowDOM

Comment 5 by hayato@chromium.org, Jan 11 2017

Labels: -Pri-3 Pri-2
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c806e7eaec2921239800ad1a907b3d347f4f4a30

commit c806e7eaec2921239800ad1a907b3d347f4f4a30
Author: hayato <hayato@chromium.org>
Date: Mon Jan 16 10:02:33 2017

Dispatch slotchange events in "notify mutation observers" steps

The spec is: https://dom.spec.whatwg.org/#notify-mutation-observers

The current behavior does not match the DOM Standard. The difference is observable
if a user mutates DOM, which will trigger a slotchange, in a mutation observer's
callback function.

See  crbug.com/671976  for details.

This CL fixes a failing wpt test, wpt/shadow-dom/slotchnage-event.html.

BUG= 649159 , 671976 

Review-Url: https://codereview.chromium.org/2622193002
Cr-Commit-Position: refs/heads/master@{#443866}

[modify] https://crrev.com/c806e7eaec2921239800ad1a907b3d347f4f4a30/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c806e7eaec2921239800ad1a907b3d347f4f4a30/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/c806e7eaec2921239800ad1a907b3d347f4f4a30/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/c806e7eaec2921239800ad1a907b3d347f4f4a30/third_party/WebKit/Source/core/dom/MutationObserver.h
[modify] https://crrev.com/c806e7eaec2921239800ad1a907b3d347f4f4a30/third_party/WebKit/Source/core/html/HTMLSlotElement.cpp
[modify] https://crrev.com/c806e7eaec2921239800ad1a907b3d347f4f4a30/third_party/WebKit/Source/core/html/HTMLSlotElement.h

Comment 7 by hayato@chromium.org, Jan 16 2017

Status: Fixed (was: Assigned)

Sign in to add a comment