New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649157 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 425896



Sign in to add a comment

Unable to open the office docs (doc, xls and ppt) files

Project Member Reported by songsuk@chromium.org, Sep 21 2016

Issue description

Chrome          : 54.0.2840.33 (Official Build) beta (64-bit)
Platform	: 8743.35.0 (Official Build) beta-channel parrot

What steps will reproduce the problem?
(1)  try to open xls or ppt files

What is the expected output? What do you see instead?
Failed to display the file.  Error message appears while opening the file (image1.png)


Please use labels and text to provide additional information.
Able to open the file on chrome 53.0.2785.128/CrOS 8530.89.0 - Blaze
 
sample.xls
367 KB Download
image1.png
33.7 KB View Download
Components: Platform>Apps>FileManager
Labels: ReleaseBlock-Beta
Cc: fukino@chromium.org
Summary: Unable to open the office docs (doc, xls and ppt) files (was: Unable to open the office docs (xls, ppt) files)
Unable to open word file also. 
Reproduced on samus and daisy.
ChromeOS:8743.35.0/Chrome:54.0.2840.33/ARC:3284275
Screenshot 2016-09-21 at 3.21.08 PM.png
206 KB View Download
Screenshot 2016-09-21 at 3.21.32 PM.png
170 KB View Download
Cc: rookrishna@chromium.org
Seen on Kip & Paine devices as well.
Was this reproducible with the last beta? 	8743.25.0	54.0.2840.24
Components: Platform>Apps>Default>ChromeOffice>Viewer
Labels: Needs-Bisect OS-Linux OS-Windows
This issue is reproducible in Linux and Windows with 55.0.2868.0 dev.

Steps to reproduce: Add Office viewer extension[https://chrome.google.com/webstore/detail/office-editing-for-docs-s/gbkeegbaiigmenfmjfclcdgdpimamgkj?utm_source=chrome-app-launcher-info-dialog] and open any .xlsx file. Attaching one for reference. 

Good Build: 55.0.2853.0 dev
Bad Build: 55.0.2854.0 dev

NOTE: This issue is not seen in 54.0.2840.14 dev but seen in 54.0.2840.34 beta.
Annual budget.xlsx
29.6 KB Download

Comment 7 by ajha@chromium.org, Sep 22 2016

Cc: jsb...@chromium.org ajha@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision OS-Mac
Owner: foolip@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on the latest canary(55.0.2868.0) on Mac OS 10.11.6 as well.

Bisect result:
==============
https://chromium.googlesource.com/chromium/src/+log/41481c71fe457b77f4d32b67b1371c79e3ab2e4e..77a58a92f789f4fd7099b2b4ff87cad27eea3067

foolip@: Could you please take a look at this.

Thank you!

Comment 8 by jsb...@chromium.org, Sep 22 2016

The extension must be calling postMessage(message, transferables, targetOrigin) and needs to correct the argument order to postMessage(message, targetOrigin, transferables)

Is the extension owner looped in?

Comment 9 by foolip@chromium.org, Sep 22 2016

This already has component Apps>Default>ChromeOffice, looking at who tends to be involved with those issues.

hlo@, developer@synerzip.com, are you involved with this extension?
Cc: respino@chromium.org elqursh@chromium.org foolip@chromium.org
Owner: respino@chromium.org
Figured out what team owns this, assigning to respino@.

In mainQOWT.js there is a postMessage call where the argument order needs to be reversed which seems to come from chromevox, see https://codereview.chromium.org/2295863002/diff/60001/chrome/browser/resources/chromeos/chromevox/chromevox/injected/api.js for how another copy of that code was fixed.
Rep# 5
Not reproduced on ChromeOS:8743.25.0/Chrome:54.0.2840.24.


This happens only with the Office viewer extension when trying to open the locally downloaded PPT, sheets & doc files.
This is marked as a beta blocker for desktop as well.  We're looking to ship that very soon, so please try to have this bug fixed no later than next Monday 9/26 so that it can be merged to branch 2840 ASAP.
ligimole@, the fix won't be in Chrome, but in the extension.

What we could do is to revert the removal from M54 and instead update the deprecation message, buying is one more release to sort out regressions like this one. Preferences?
Cc: develo...@synerzip.com
Owner: hlo@chromium.org
No longer with the ChromeOffice team. Assigning hlo and cc'ing developer at synerzip to the bug.
foolip@, ligimole@ : I can see that this was fixed in the internal repo (4 weeks ago).
https://quickoffice-internal.googlesource.com/html-office/+/d375b6e3a2940ea6d149a6974658527fe1c8ec25

Because ChromeOffice (aka OCM) is on a 6 weeks release cycle it is part of the latest release cut yesterday. That release won't be going to beta branch as far as I know. hlo@ can advise.

In my opinion, reverting removal in M54 will be a safer option.
Reproducible on CrOS M55 Latest build 8825.0.0 / 55.0.2866.0 - Paine as well.
Status: Fixed (was: Assigned)
OK, I'll revert the removal on M54, sounds like one release cycle more should be enough though. Closing this since it has in fact been fixed already.
Blocking: 425896
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 23 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e8f6388671df5060e592759831ea27a1a84e38

commit 02e8f6388671df5060e592759831ea27a1a84e38
Author: foolip <foolip@chromium.org>
Date: Fri Sep 23 11:24:40 2016

Revert "Remove window.postMessage(message, transferables, targetOrigin) legacy overload"

This reverts commits a91dd1d7611e879f8d03bf533c45fa229ed7246d and
48caa2cebaf1723dcfd8665e4859d90e2b55f2a2.

In addition:
 * Update the deprecation message for M55 removal.
 * Exclude changes to postMessage calls outside of tests, as those might
   otherwise trigger the deprecation message.

BUG= 425896 , 649157 
TBR=sigbjornf@opera.com,haraken@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2362693004
Cr-Commit-Position: refs/branch-heads/2840@{#509}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/Source/core/frame/UseCounter.h

Issue 649106 has been merged into this issue.
Labels: TE-Verified-54.0.2840.41 TE-Verified-M54
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 54.0.2840.41 with the sample.xls file.able to open file without any error.
Please find the attached screen cast for the same.

Adding TE-Verified labels.

Thanks,
649157.mp4
2.6 MB View Download
Status: Verified (was: Fixed)
Verified on 54.0.2840.43/8743.44.0 cyan
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02e8f6388671df5060e592759831ea27a1a84e38

commit 02e8f6388671df5060e592759831ea27a1a84e38
Author: foolip <foolip@chromium.org>
Date: Fri Sep 23 11:24:40 2016

Revert "Remove window.postMessage(message, transferables, targetOrigin) legacy overload"

This reverts commits a91dd1d7611e879f8d03bf533c45fa229ed7246d and
48caa2cebaf1723dcfd8665e4859d90e2b55f2a2.

In addition:
 * Update the deprecation message for M55 removal.
 * Exclude changes to postMessage calls outside of tests, as those might
   otherwise trigger the deprecation message.

BUG= 425896 , 649157 
TBR=sigbjornf@opera.com,haraken@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2362693004
Cr-Commit-Position: refs/branch-heads/2840@{#509}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args-expected.txt
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/LayoutTests/fast/dom/Window/window-postmessage-args.html
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/02e8f6388671df5060e592759831ea27a1a84e38/third_party/WebKit/Source/core/frame/UseCounter.h

Sign in to add a comment