New issue
Advanced search Search tips

Issue 649153 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 636622



Sign in to add a comment

Eliminate GYP from chromeos-chrome ebuild

Project Member Reported by steve...@chromium.org, Sep 21 2016

Issue description

Now that GYP support is deprecated we should eliminate references to it in the chromeos-chrome ebuild to improve maintainability and reduce confusion.

We should do this before other long overdue cleanup.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/da8d9f0416792f9feffc69e581ffb776d9464a76

commit da8d9f0416792f9feffc69e581ffb776d9464a76
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Sep 23 20:25:45 2016

cros_chrome_sdk / deploy_chrome: Use GN_ARGS (or --gn-args)

This replaces the use of GYP_DEFINES (or --gyp-defines).

This also uses the more correct gn_args[is_chrome_branded] = True
test for copying libwidevine*.so foles.

BUG= chromium:649153 
TEST=./cbuildbot/run_tests scripts/deploy_chrome_unittest lib/chrome_util_unittest cli/cros/cros_chrome_sdk_unittest
CQ-DEPEND=CL:389959

Change-Id: I060e4c6dda4ddc33a53095ffbb06dba756d4f714
Reviewed-on: https://chromium-review.googlesource.com/390331
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/da8d9f0416792f9feffc69e581ffb776d9464a76/cli/cros/cros_chrome_sdk.py
[modify] https://crrev.com/da8d9f0416792f9feffc69e581ffb776d9464a76/scripts/deploy_chrome.py
[modify] https://crrev.com/da8d9f0416792f9feffc69e581ffb776d9464a76/cli/cros/cros_chrome_sdk_unittest.py
[modify] https://crrev.com/da8d9f0416792f9feffc69e581ffb776d9464a76/lib/chrome_util.py
[modify] https://crrev.com/da8d9f0416792f9feffc69e581ffb776d9464a76/cbuildbot/stages/chrome_stages.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 5 2016

Labels: merge-merged-release-R54-8743.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/0fd6dbcfd02748ccf66fe5d3909cad1877fefdae

commit 0fd6dbcfd02748ccf66fe5d3909cad1877fefdae
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Sep 27 18:05:39 2016

chromeos-chrome: Pass GN_ARGS to deploy_chrome

BUG= chromium:649153 
TEST=emerge-${BOARD} chromeos-chrome

Change-Id: If320638deb7cbb14f34772e10c2542b3b99d8448
Reviewed-on: https://chromium-review.googlesource.com/389959
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit 79a8520dabe1cc676ed5253b53aba0b974c4fec5)
Reviewed-on: https://chromium-review.googlesource.com/393358
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/0fd6dbcfd02748ccf66fe5d3909cad1877fefdae/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Labels: M-56
Components: Build
Labels: -M-56 M-57
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/40d2051084d99cf806f97a60f56722d44d08ba4d

commit 40d2051084d99cf806f97a60f56722d44d08ba4d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Dec 12 21:59:46 2016

Eliminate gyp refrences, BUILD_DEFINES, and use=gn from ebuild

BUG= chromium:649153 
TEST=pfq-informational

Change-Id: I1bb05d9538746b85132251ffb5e8b6fa2d9efe19
Reviewed-on: https://chromium-review.googlesource.com/419079
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/40d2051084d99cf806f97a60f56722d44d08ba4d/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4a5b59da9f2edb57a9cd8c579b2ca18245f01d11

commit 4a5b59da9f2edb57a9cd8c579b2ca18245f01d11
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Dec 14 20:48:38 2016

chromeos-chrome ebuild: Additional cleanup

* Remove unnecessary GYP related code
* Convert debugging eerror -> einfo

BUG= chromium:649153 
TEST=none

Change-Id: Ie8c4c09a9e2b8d07316e7a0c41e25b95a2aa854d
Reviewed-on: https://chromium-review.googlesource.com/420179
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/4a5b59da9f2edb57a9cd8c579b2ca18245f01d11/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Status: Fixed (was: Started)

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment