Issue metadata
Sign in to add a comment
|
Scrollbar fade animation broken on Android |
||||||||||||||||||||||
Issue descriptionSteps: 1) Visit any page (e.g. http://nytimes.com/) on 54.0.2840.25 or ToT 2) Observe the scrollbar to the right remains solid gray and never fades. I bisected to https://codereview.chromium.org/2256733003 "Touchpad scroll latching enabled for Mac behind flag." I suppose one of the new ClearCurrentlyScrollingLayer calls are to blame. This doesn't cleanly revert on ToT, but it should on M54 given that it just barely made branch point.
,
Sep 21 2016
,
Sep 21 2016
Requesting merge of revert https://codereview.chromium.org/2358993002/ (to be directly reverted on branch, not reverted on ToT).
,
Sep 21 2016
The problem is the new early return in ScrollBegin (in case of being in inertial phase) that skips the scrollBeginImpl call. I am working on it now.
,
Sep 22 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c3fb5ce116a30a768d2eb52aa146af72059ac5 commit 08c3fb5ce116a30a768d2eb52aa146af72059ac5 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Sep 22 21:42:02 2016 Revert "Touchpad scroll latching enabled for Mac behind flag." This reverts commit r414515 on the M54 branch to fix Android scrollbar fading. BUG=526463, 649122 (cherry picked from commit 3700dfcb06e419d4a900e8e0de540979a9119be9) Review URL: https://codereview.chromium.org/2360963003 . Cr-Commit-Position: refs/branch-heads/2840@{#498} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/ui/events/blink/input_handler_proxy.cc
,
Sep 23 2016
,
Sep 28 2016
Verified fix with chrome Beta release '54.0.2840.42' on Sony xperia Z1/5.1.1
,
Sep 29 2016
,
Sep 29 2016
Still repro on 55.0.2874.0. If a change landed to fix it on trunk after that, could you mention it here before you close?
,
Sep 29 2016
You're right, I thought the patch is reverted in M55, as well.
,
Oct 18 2016
Does this need a merge label for M55?
,
Oct 24 2016
,
Oct 25 2016
This regression is again visible on 55.0.2883.18 beta. This is a 55 stable blocker so please fix ASAP and cherry-pick again. And please fix on ToT this time.
,
Oct 26 2016
I have a cl under review. Will be landed today/tomorrow.
,
Oct 26 2016
,
Oct 26 2016
[Automated comment] Commit may have occurred before M55 branch point (10/6/2016), needs manual review.
,
Oct 26 2016
[Automated comment] Commit may have occurred before M55 branch point (10/6/2016), needs manual review.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c3fb5ce116a30a768d2eb52aa146af72059ac5 commit 08c3fb5ce116a30a768d2eb52aa146af72059ac5 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Sep 22 21:42:02 2016 Revert "Touchpad scroll latching enabled for Mac behind flag." This reverts commit r414515 on the M54 branch to fix Android scrollbar fading. BUG=526463, 649122 (cherry picked from commit 3700dfcb06e419d4a900e8e0de540979a9119be9) Review URL: https://codereview.chromium.org/2360963003 . Cr-Commit-Position: refs/branch-heads/2840@{#498} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/08c3fb5ce116a30a768d2eb52aa146af72059ac5/ui/events/blink/input_handler_proxy.cc
,
Nov 2 2016
Merge of revert for M55 is approved.
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6036a082e4eea1c402dbd5d294dee1581ff201a commit d6036a082e4eea1c402dbd5d294dee1581ff201a Author: sahel <sahel@chromium.org> Date: Wed Nov 02 17:23:44 2016 Revert "Touchpad scroll latching enabled for Mac behind flag." This fixes Android scrollbar fading regression. reverted cl: https://crrev.com/2256733003 TBR=aelias@chromium.org BUG= 649122 , 526463 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2467023003 Cr-Commit-Position: refs/heads/master@{#429316} [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/d6036a082e4eea1c402dbd5d294dee1581ff201a/ui/events/blink/input_handler_proxy.cc
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f commit acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f Author: Tim Dresser <tdresser@chromium.org> Date: Fri Nov 04 15:28:43 2016 Revert "Touchpad scroll latching enabled for Mac behind flag." This fixes Android scrollbar fading regression. reverted cl: https://crrev.com/2256733003 R=aelias@chromium.org TBR=aelias@chromium.org BUG= 649122 , 526463 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2467023003 Cr-Commit-Position: refs/heads/master@{#429316} (cherry picked from commit d6036a082e4eea1c402dbd5d294dee1581ff201a) Review URL: https://codereview.chromium.org/2472943003 . Cr-Commit-Position: refs/branch-heads/2883@{#455} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/cc/trees/layer_tree_host_unittest_scroll.cc [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/content/browser/renderer_host/input/mouse_wheel_event_queue.cc [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc [modify] https://crrev.com/acaaa7ee55c9e37b0ee8a6f09dbf90555e44227f/ui/events/blink/input_handler_proxy.cc
,
Nov 4 2016
Thanks!
,
Nov 9 2016
Works as per expected behavior, Scroll bar fades out while scrolling the page. Issue verified on 55.0.2883.45 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Sep 21 2016