New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 649111 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 231752



Sign in to add a comment

Composited sticky position jitters while scrolling.

Project Member Reported by flackr@chromium.org, Sep 21 2016

Issue description

Version: 55.0.2868.0 (Developer Build) (64-bit)
Revision: c25b23acf5c133b941ee35cb7a0e32b1e539dfbd-refs/heads/master@{#420151}

What steps will reproduce the problem?
(1) With experimental web platform features enabled, open http://output.jsbin.com/siyidi
(2) Scroll the page.

What is the expected output?
The sticky header should be solidly stuck in place.

What do you see instead?
Instead it jitters by a pixel. This is likely because we need to account for the scroll snapping done to align scrolling content positions to even device pixel values.

Please use labels and text to provide additional information.

 

Comment 1 by flackr@chromium.org, Oct 14 2016

Cc: flackr@chromium.org
 Issue 649146  has been merged into this issue.

Comment 2 by flackr@chromium.org, Oct 14 2016

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc5dfbe3795799bca5bc856fd391b754afb775b0

commit dc5dfbe3795799bca5bc856fd391b754afb775b0
Author: flackr <flackr@chromium.org>
Date: Mon Oct 24 21:43:38 2016

Include scroll snap in scroll position used for sticky offset calculation.

BUG= 649111 
TEST=LayerTreeHostCommonTest.StickyPositionSubpixelScroll
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2432043007
Cr-Commit-Position: refs/heads/master@{#427161}

[modify] https://crrev.com/dc5dfbe3795799bca5bc856fd391b754afb775b0/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/dc5dfbe3795799bca5bc856fd391b754afb775b0/cc/trees/property_tree.cc

Comment 5 by flackr@chromium.org, Oct 26 2016

There is just one more issue which causes jitter while hiding / showing the top controls. The fix is in review: https://codereview.chromium.org/2451183002.
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a283bedb5251108878e9cd71539464641eeec21b

commit a283bedb5251108878e9cd71539464641eeec21b
Author: flackr <flackr@chromium.org>
Date: Mon Oct 31 14:49:42 2016

Add sticky nodes affected by inner and outer viewport bounds deltas.

We need to additionally add sticky nodes affected by the outer viewport bounds, which is the common case on Android. Sticky nodes are not moved unconditionally by viewport bounds deltas though since they have constraints on their movement.

BUG= 649111 
TEST=LayerTreeHostCommonTest.StickyPositionBottomInnerViewportDelta,LayerTreeHostCommonTest.StickyPositionBottomOuterViewportDelta
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2451183002
Cr-Commit-Position: refs/heads/master@{#428708}

[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/proto/property_tree.proto
[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/trees/layer_tree_host_common_unittest.cc
[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/trees/property_tree.cc
[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/trees/property_tree_builder.cc
[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/trees/property_tree_unittest.cc
[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/trees/transform_node.cc
[modify] https://crrev.com/a283bedb5251108878e9cd71539464641eeec21b/cc/trees/transform_node.h

Comment 7 by flackr@chromium.org, Oct 31 2016

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on Pixel XL/NMF26E with Latest M56 build.

Sign in to add a comment