Switch ANGLE to ES3 by default in Chrome |
||||
Issue descriptionThis is necessary for WebGL2. In theory it should be low risk for the following reasons: 1) WebGL2 conformance suite tests extensively various ES3 paths 2) Chrome command buffer already runs on top of ES3 drivers in Android So both ANGLE ES3 implementation and command buffer ES3 port should be in good shape to make this switch. We also need to have a commandline switch and a blacklist feature to disable ANGLE ES3 (maybe just --disable-angle-es3), which will implicitly disable WebGL2.
,
Sep 22 2016
We only need to make one change on Windows - to make sure we're requiring D3D 10.1 (not 10.0) for ES3. There's a couple places where we check this correctly and a couple where we don't. I'll take a look at fixing this tomorrow.
,
Sep 22 2016
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/e8a7849613e5afa5b4ba223631d08278fbbae329 commit e8a7849613e5afa5b4ba223631d08278fbbae329 Author: Jamie Madill <jmadill@chromium.org> Date: Thu Sep 22 17:08:39 2016 D3D11: Restrict ES3 bits to FL 10.1. We would advertise ES3 in some cases when we didn't support it. BUG= angleproject:1381 BUG= chromium:649101 Change-Id: I2a5bbc1d6153cdfc6c9c577aa0b82caf8482a42d Reviewed-on: https://chromium-review.googlesource.com/388190 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/e8a7849613e5afa5b4ba223631d08278fbbae329/src/libANGLE/renderer/d3d/d3d11/Renderer11.cpp
,
Sep 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f507a4425364347073fa5e07fd90d8b2ba6084c5 commit f507a4425364347073fa5e07fd90d8b2ba6084c5 Author: zmo <zmo@chromium.org> Date: Fri Sep 23 23:15:13 2016 Roll ANGLE 28a97ee..e8a7849 https://chromium.googlesource.com/angle/angle.git/+log/28a97ee..e8a7849 BUG= chromium:649101 , chromium:649200 TBR=kbr@chromium.org,jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2360203005 Cr-Commit-Position: refs/heads/master@{#420773} [modify] https://crrev.com/f507a4425364347073fa5e07fd90d8b2ba6084c5/DEPS
,
Sep 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d78d37f99d13ec5eef3570badd4959c36e367342 commit d78d37f99d13ec5eef3570badd4959c36e367342 Author: zmo <zmo@chromium.org> Date: Sat Sep 24 00:54:24 2016 Enable ANGLE ES3 by default in Chromium (Windows) We can use --disable-es3-angle or driver bug workaround list to turn it off if it's problematic on certain platforms. BUG= 649101 TEST=win bots R=piman@chromium.org,kbr@chromium.org,geofflang@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2354423002 Cr-Commit-Position: refs/heads/master@{#420802} [modify] https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342/content/browser/gpu/gpu_data_manager_impl_private.cc [modify] https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342/gpu/config/gpu_driver_bug_workaround_type.h [modify] https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342/ui/gl/gl_context_egl.cc [modify] https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342/ui/gl/gl_switches.cc [modify] https://crrev.com/d78d37f99d13ec5eef3570badd4959c36e367342/ui/gl/gl_switches.h
,
Sep 25 2016
Slight correction: the command line flag to disable the use of ES3 by default is --disable_es3_gl_context .
,
Nov 8 2016
,
Jun 20 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zmo@chromium.org
, Sep 21 2016