New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649083 link

Starred by 2 users
Status: WontFix
Owner:
█ chingcodes@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
dgarr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

"cbuldbot --remote XXX --buildbot" shouldn't work.

Project Member Reported by dgarr...@chromium.org, Sep 21 2016 
People are creating fake release builds by explicitly passing --buildbot to tryjobs. This doesn't work right (generated only partial release artifacts), and isn't supported.

We should explicitly block this behavior.

Comment 1 by sbasi@chromium.org, Sep 27 2016

Cc: dgarr...@chromium.org
Owner: chingcodes@chromium.org
Triaging bugs. Don confirmed this is a good starter bug for you Chris.

Comment 2 by autumn@chromium.org, Sep 27 2016

Labels: -current-issue

Comment 3 by chingcodes@chromium.org, Sep 28 2016

Status: Assigned (was: Untriaged)
Where should this be controlled?

In my first look, should I add a check in remote_try.py and fail if '--buildbot' is sent, or do I just make '--remote' and '--buildbot' mutually exclusive in cbuildbot?

Comment 4 by dgarr...@chromium.org, Sep 28 2016 

When I filed this, I was just thinking that --remote and --buildbot should be mutually exclusive.

However, there are some cases floating by where we might need to start supporting this, which makes the bug a lot harder.

If we wish to support it, we probaby want to stop calling "OverrideConfigForTrybot" if --buildbot was set, but I haven't investigated enough to see if that is really the right answer.

Comment 5 by dgarr...@chromium.org, Jan 18 2017

Status: WontFix (was: Assigned)
►

Sign in to add a comment