New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 649082 link

Starred by 3 users
Status: Fixed
Owner:
shivanisha@chromium.org
Closed: Oct 2016
Cc:
█ bmcquade@chromium.org
jkarlin@chromium.org
█ kenjibaheux@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 640844



Sign in to add a comment

Send a warning level intervention header in GET for doc.written scripts that can be potentially blocked.

Project Member Reported by shivanisha@chromium.org, Sep 21 2016 
In cases where doc.write blocking intervention could have applied had it not been a faster connection or a reload, send a warning level intervention header in the GET request:
Intervention: <https://www.chromestatus.com/feature/5718547946799104> ; level="warning"
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be2bff3df41039c4d3e92680b8ebb72f17a45ae

commit 6be2bff3df41039c4d3e92680b8ebb72f17a45ae
Author: shivanisha <shivanisha@chromium.org>
Date: Wed Oct 05 19:47:03 2016

In cases where doc.write blocking intervention could have applied had it
not been a faster connection or a reload, send a warning level
intervention header in the GET request:
Intervention: <https://www.chromestatus.com/feature/5718547946799104> ;
level="warning"
BUG= 649082 

Review-Url: https://codereview.chromium.org/2389753002
Cr-Commit-Position: refs/heads/master@{#423257}

[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-expected.txt
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/fetch/FetchContext.h
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/testing/Internals.idl

Comment 2 by l446240525@gmail.com, Oct 6 2016 

Can you merge this CL to M54?

Comment 3 by shivanisha@chromium.org, Oct 14 2016

Status: Fixed (was: Started)

Comment 4 by kenjibaheux@chromium.org, Oct 24 2016

Blocking: 640844
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6be2bff3df41039c4d3e92680b8ebb72f17a45ae

commit 6be2bff3df41039c4d3e92680b8ebb72f17a45ae
Author: shivanisha <shivanisha@chromium.org>
Date: Wed Oct 05 19:47:03 2016

In cases where doc.write blocking intervention could have applied had it
not been a faster connection or a reload, send a warning level
intervention header in the GET request:
Intervention: <https://www.chromestatus.com/feature/5718547946799104> ;
level="warning"
BUG= 649082 

Review-Url: https://codereview.chromium.org/2389753002
Cr-Commit-Position: refs/heads/master@{#423257}

[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-expected.txt
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/fetch/FetchContext.h
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae/third_party/WebKit/Source/core/testing/Internals.idl

Comment 6 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
►

Sign in to add a comment