New issue
Advanced search Search tips

Issue 649075 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Refactor method URLIndexPrivateData::HistoryItemsForTerms

Reported by open.hyp...@gmail.com, Sep 21 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 Safari/537.36

Steps to reproduce the problem:
The current checked in version of URLIndexPrivateData::HistoryItemsForTerms contains a lot of copy-and-paste duplicate code.

What is the expected behavior?

What went wrong?
URLIndexPrivateData::HistoryItemsForTerms needs to be refactored to remove duplicate code.

Did this work before? Yes It currently works.  It just needs to be refactored.

Chrome version: 53.0.2785.116  Channel: stable
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 23.0 r0
 
The copy-and-paste code was submitted in issue 2187343002, which has been closed.
Components: UI>Browser>History

Comment 3 by shrike@chromium.org, Sep 22 2016

Labels: OS-Linux OS-Windows
Status: Available (was: Unconfirmed)
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 25 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment