New issue
Advanced search Search tips

Issue 649069 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

M54 PFQ broken in Build Package

Project Member Reported by josa...@chromium.org, Sep 21 2016

Issue description

Log snippet: 

chromeos-chrome-54.0.2840.34_rc-r1: [17263/30677] CXX obj/storage/browser/browser/database_tracker.o
chromeos-chrome-54.0.2840.34_rc-r1: [17264/30677] ACTION //chrome/app:generated_resources_grit(//build/toolchain/cros:target)
chromeos-chrome-54.0.2840.34_rc-r1: ninja: build stopped: subcommand failed.
chromeos-chrome-54.0.2840.34_rc-r1:  * ERROR: chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1::chromiumos failed (compile phase):
chromeos-chrome-54.0.2840.34_rc-r1:  *   (no error message)
chromeos-chrome-54.0.2840.34_rc-r1:  * 
chromeos-chrome-54.0.2840.34_rc-r1:  * Call stack:
chromeos-chrome-54.0.2840.34_rc-r1:  *     ebuild.sh, line   93:  Called src_compile
chromeos-chrome-54.0.2840.34_rc-r1:  *   environment, line 3784:  Called chrome_make 'chrome_sandbox' 'libosmesa.so' 'chrome' 'media_unittests' 'sandbox_linux_unittests' 'video_decode_accelerator_unittest' 'video_encode_accelerator_unittest' 'ppapi/examples/video_decode' 'bitmaptools' 'clear_system_cache' 'minidump_stackwalk' 'chromedriver' 'nacl_helper_bootstrap' 'nacl_helper'
chromeos-chrome-54.0.2840.34_rc-r1:  *   environment, line 1059:  Called die
chromeos-chrome-54.0.2840.34_rc-r1:  * The specific snippet of code:
chromeos-chrome-54.0.2840.34_rc-r1:  *       PATH=${PATH}:/home/$(whoami)/depot_tools ${ENINJA} ${MAKEOPTS} -C "${BUILD_OUT_SYM}/${BUILDTYPE}" $(usex verbose -v "") "$@" || die
chromeos-chrome-54.0.2840.34_rc-r1:  * 
chromeos-chrome-54.0.2840.34_rc-r1:  * If you need support, post the output of `emerge --info '=chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1::chromiumos'`,
chromeos-chrome-54.0.2840.34_rc-r1:  * the complete build log and the output of `emerge -pqv '=chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1::chromiumos'`.
chromeos-chrome-54.0.2840.34_rc-r1:  * The complete build log is located at '/build/samus/tmp/portage/logs/chromeos-base:chromeos-chrome-54.0.2840.34_rc-r1:20160921-175013.log'.
chromeos-chrome-54.0.2840.34_rc-r1:  * For convenience, a symlink to the build log is located at '/build/samus/tmp/portage/chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1/temp/build.log'.
chromeos-chrome-54.0.2840.34_rc-r1:  * The ebuild environment file is located at '/build/samus/tmp/portage/chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1/temp/environment'.
chromeos-chrome-54.0.2840.34_rc-r1:  * Working directory: '/home/chrome-bot/chrome_root/src'
chromeos-chrome-54.0.2840.34_rc-r1:  * S: '/build/samus/tmp/portage/chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1/work/chromeos-chrome-54.0.2840.34_rc'
chromeos-chrome-54.0.2840.34_rc-r1: >>> Failed to emerge chromeos-base/chromeos-chrome-54.0.2840.34_rc-r1 for /build/samus/, Log file:
chromeos-chrome-54.0.2840.34_rc-r1: >>>  '/build/samus/tmp/portage/logs/chromeos-base:chromeos-chrome-54.0.2840.34_rc-r1:20160921-175013.log'

Full log: 
https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R54-8743.B/builds/111/steps/BuildPackages/logs/stdio

Seems like this started with 54.0.2840.34 but I could not find anything obvious in the diff: https://chromium.googlesource.com/chromium/src/+log/54.0.2840.32..54.0.2840.34?pretty=fuller&n=10000


stevenjb, could you help debugging/forwarding this one?

 
This is the compile error:

chromeos-chrome-54.0.2840.34_rc-r1: FAILED: obj/ash/ash/palette_tool_manager.o 
chromeos-chrome-54.0.2840.34_rc-r1: x86_64-cros-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/ash/ash/palette_tool_manager.o.d -DASH_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_RLZ -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DTOOLKIT_VIEWS=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DENABLE_WEBSOCKETS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DMESA_EGL_NO_X11_HEADERS -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -Igen/ash/common/strings -Igen/ash/resources -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ced/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebm/source -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/opus/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -I/build/samus/usr/include/nss -I/build/samus/usr/include/nspr -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/boringssl/src/include -Igen -Igen/ui/views/resources -Igen/ui/resources -Igen/ui/resources -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/mesa/src/include -I/build/samus/usr/include/dbus-1.0 -I/build/samus/usr/lib64/dbus-1.0/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/WebKit -Igen/third_party/WebKit -I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/qcms/src -Igen/ui/chromeos/resources -Igen/ui/chromeos/strings -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -m64 -march=x86-64 -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../../../../../../build/samus -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -pipe -pipe -march=corei7 -D__google_stl_debug_vector=1  -c ../../../../../../../home/chrome-bot/chrome_root/src/ash/common/system/chromeos/palette/palette_tool_manager.cc -o obj/ash/ash/palette_tool_manager.o
chromeos-chrome-54.0.2840.34_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ash/common/system/chromeos/palette/palette_tool_manager.cc: In member function 'gfx::VectorIconId ash::PaletteToolManager::GetActiveTrayIcon(ash::PaletteToolId)':
chromeos-chrome-54.0.2840.34_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ash/common/system/chromeos/palette/palette_tool_manager.cc:78:12: error: 'PALETTE_TRAY_ICON_DEFAULT' is not a member of 'gfx::VectorIconId'
chromeos-chrome-54.0.2840.34_rc-r1:      return gfx::VectorIconId::PALETTE_TRAY_ICON_DEFAULT;
Owner: jdufault@chromium.org
Status: Assigned (was: Untriaged)
It was almost certain this cherry-pick:

https://chromium.googlesource.com/chromium/src/+/30b876f46ac2de53e6f068622d201a09ac1d4bb2

Jacob, did you compile the branch after your cherry pick? :)

We should probably revert that for now.

Status: Started (was: Assigned)
I strongly prefer cherry picking a fix in - it should not take much longer than reverting. Working on it now.

This CL had a number of merge issues; local compilation succeeded yesterday after some local changes, but I don't think they got picked up by the cherry pick.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 21 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3513bccc1d4b909bba5a45a3da712b6db5218642

commit 3513bccc1d4b909bba5a45a3da712b6db5218642
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Sep 21 19:25:38 2016

Fix m54 build caused by bad merge.

BUG= 649069 

(cherry picked from commit 5f21d8f4e4a64fbd54c76b571652d9d014ad3017)

Review URL: https://codereview.chromium.org/2361533002 .

Cr-Commit-Position: refs/branch-heads/2840@{#468}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/3513bccc1d4b909bba5a45a3da712b6db5218642/ash/common/system/chromeos/palette/palette_tool_manager.cc

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3513bccc1d4b909bba5a45a3da712b6db5218642

commit 3513bccc1d4b909bba5a45a3da712b6db5218642
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Sep 21 19:25:38 2016

Fix m54 build caused by bad merge.

BUG= 649069 

(cherry picked from commit 5f21d8f4e4a64fbd54c76b571652d9d014ad3017)

Review URL: https://codereview.chromium.org/2361533002 .

Cr-Commit-Position: refs/branch-heads/2840@{#468}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/3513bccc1d4b909bba5a45a3da712b6db5218642/ash/common/system/chromeos/palette/palette_tool_manager.cc

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment