[MD Settings] Empty state string fixes for autofill and passwords |
|||||||||
Issue descriptionchrome://settings/autofill chrome://settings/managePasswords Current strings on MD Settings don't describe the status correctly: No addresses were found No credit cards were found (Saved passwords:) No passwords were found (Never saved:) Passwords saved for all websites Proposed strings: Saved addresses will appear here Saved cards will appear here (Saved passwords:) Saved passwords will appear here (Never saved:) Sites which never save passwords will appear here
,
Sep 21 2016
SGTM ccing some relevant folks (the proposal also removes the periods from these empty state sentences)
,
Nov 17 2016
,
Nov 17 2016
Hector: can you audit that single-sentence strings omit periods? it's what Material Design wants
,
Jan 6 2017
,
Jan 9 2017
,
Mar 17 2017
,
Mar 17 2017
,
Mar 17 2017
I worked on another bug where Alan stated that if a single sentence string is followed by a "learn-more" link (or any link), keep the period to separate them, so I'll checking the string usage and following that rule as I sweep.
,
Mar 17 2017
In addition to the strings reported in the original bug, I also changed the not-found string for:
- spellcheck dictionary ("No custom words found" -> "Saved custom words will appear here")
- search engine ("No other search engine found" -> "Other saved search engines will appear here")
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36641a83225cc90dc457dab7f0db405429448ed4 commit 36641a83225cc90dc457dab7f0db405429448ed4 Author: scottchen <scottchen@chromium.org> Date: Mon Mar 20 23:07:02 2017 MD Settings: Strings sweep. Tweak wording for not-found messages in lists, and remove periods from single sentences that are not followed by anything else. Note that some single-sentence strings in settings_strings.grdp still has periods, because in the UI they're either followed by another sentence or a link. BUG= 649068 Review-Url: https://codereview.chromium.org/2758073002 Cr-Commit-Position: refs/heads/master@{#458222} [modify] https://crrev.com/36641a83225cc90dc457dab7f0db405429448ed4/chrome/app/settings_chromium_strings.grdp [modify] https://crrev.com/36641a83225cc90dc457dab7f0db405429448ed4/chrome/app/settings_google_chrome_strings.grdp [modify] https://crrev.com/36641a83225cc90dc457dab7f0db405429448ed4/chrome/app/settings_strings.grdp [modify] https://crrev.com/36641a83225cc90dc457dab7f0db405429448ed4/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Mar 21 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by hwi@chromium.org
, Sep 21 2016